-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-33481: set the node tag used by CAPG for CloudProviderConfig #8386
OCPBUGS-33481: set the node tag used by CAPG for CloudProviderConfig #8386
Conversation
/test altinfra-e2e-gcp-capi-ovn |
@bfournie: This pull request references Jira Issue OCPBUGS-33481, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/label platform/google |
/cc @barbacbd |
/jira refresh |
@bfournie: This pull request references Jira Issue OCPBUGS-33481, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/test altinfra-e2e-gcp-capi-ovn |
/test altinfra-e2e-gcp-capi-ovn |
/test altinfra-e2e-gcp-capi-ovn CI infrastructure issue |
/approve This LGTM but will wait for tests to confirm, |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/shellcheck |
@bfournie: Overrode contexts on behalf of bfournie: ci/prow/shellcheck In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@bfournie: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/override ci/prow/shellcheck |
@bfournie: Overrode contexts on behalf of bfournie: ci/prow/shellcheck In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
412a878
into
openshift:master
@bfournie: Jira Issue OCPBUGS-33481: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-33481 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Fix included in accepted release 4.16.0-0.nightly-2024-05-14-095225 |
The CAPI GCP provider uses the
control-plane
tag for what is tagged asmaster
nodes by Terraform. Set thecontrol-plane
as a nodeTag in the CloudProviderConfig to ensure traffic is passed through the firewall.