Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-33481: set the node tag used by CAPG for CloudProviderConfig #8386

Merged
merged 1 commit into from
May 13, 2024

Conversation

bfournie
Copy link
Contributor

@bfournie bfournie commented May 9, 2024

The CAPI GCP provider uses the control-plane tag for what is tagged as master nodes by Terraform. Set the control-plane as a nodeTag in the CloudProviderConfig to ensure traffic is passed through the firewall.

@bfournie
Copy link
Contributor Author

bfournie commented May 9, 2024

/test altinfra-e2e-gcp-capi-ovn

@openshift-ci openshift-ci bot requested review from patrickdillon and rwsu May 9, 2024 20:55
@bfournie bfournie changed the title DNM: test of tags applied to k8s-fw for CAPG OCPBUGS-33481: set the node tag used by CAPG for CloudProviderConfig May 9, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 9, 2024
@openshift-ci-robot
Copy link
Contributor

@bfournie: This pull request references Jira Issue OCPBUGS-33481, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 9, 2024
@bfournie
Copy link
Contributor Author

bfournie commented May 9, 2024

/label platform/google

@bfournie
Copy link
Contributor Author

bfournie commented May 9, 2024

/cc @barbacbd

@bfournie
Copy link
Contributor Author

bfournie commented May 9, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 9, 2024
@openshift-ci-robot
Copy link
Contributor

@bfournie: This pull request references Jira Issue OCPBUGS-33481, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bfournie
Copy link
Contributor Author

/test altinfra-e2e-gcp-capi-ovn

@bfournie
Copy link
Contributor Author

/test altinfra-e2e-gcp-capi-ovn

@patrickdillon
Copy link
Contributor

/test altinfra-e2e-gcp-capi-ovn

CI infrastructure issue

@patrickdillon
Copy link
Contributor

/approve

This LGTM but will wait for tests to confirm,

Copy link
Contributor

openshift-ci bot commented May 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2024
@bfournie
Copy link
Contributor Author

/override ci/prow/shellcheck

Copy link
Contributor

openshift-ci bot commented May 10, 2024

@bfournie: Overrode contexts on behalf of bfournie: ci/prow/shellcheck

In response to this:

/override ci/prow/shellcheck

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented May 10, 2024

@bfournie: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-ovn-upgrade ccdea83 link false /test okd-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@barbacbd barbacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 7f7c54c and 2 for PR HEAD ccdea83 in total

@bfournie
Copy link
Contributor Author

/override ci/prow/shellcheck

Copy link
Contributor

openshift-ci bot commented May 13, 2024

@bfournie: Overrode contexts on behalf of bfournie: ci/prow/shellcheck

In response to this:

/override ci/prow/shellcheck

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 412a878 into openshift:master May 13, 2024
24 of 25 checks passed
@openshift-ci-robot
Copy link
Contributor

@bfournie: Jira Issue OCPBUGS-33481: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33481 has been moved to the MODIFIED state.

In response to this:

The CAPI GCP provider uses the control-plane tag for what is tagged as master nodes by Terraform. Set the control-plane as a nodeTag in the CloudProviderConfig to ensure traffic is passed through the firewall.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-05-14-095225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. platform/google
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants