OCPBUGS-33661: capi/aws: rename preserveBootstrapIgnition
#8460
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@r4f4: This pull request references Jira Issue OCPBUGS-33661, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/invalid-bug
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-bug
|
@r4f4: This pull request references Jira Issue OCPBUGS-33661, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (yunjiang@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
|
If #8410 gets merged first, then this PR should be updated to use the new field name in the check introduced by 8410. |
r4f4
force-pushed
the
capi-aws-preserve-ignition-rename
branch
from
15619b3
to
6e22c63
Compare
|
Update: fixed the printer unit tests. |
|
/test e2e-aws-ovn |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: barbacbd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/cherry-pick release-4.16 |
|
@r4f4: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/okd-images |
|
@r4f4: Overrode contexts on behalf of r4f4: ci/prow/okd-images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
The name doesn't really reflect the purpose of the field, but the terraform implementation instead. Since the implementation has changed in capi/capa, let's rename it so users don't expect the ignition object to not be destroyed when there are enough permissions. The old field is kept for the deprecation period but will be removed in the future in favor of the new `BestEffortDeleteIgnition`.
r4f4
force-pushed
the
capi-aws-preserve-ignition-rename
branch
from
6e22c63
to
f5cfcd4
Compare
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@r4f4: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
openshift-merge-bot
bot
merged commit 9f02731
into
openshift:master
|
@r4f4: Jira Issue OCPBUGS-33661: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-33661 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@r4f4: new pull request created: #8574 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-installer-altinfra-container-v4.17.0-202406120214.p0.g9f02731.assembly.stream.el9 for distgit ose-installer-altinfra. |
The name doesn't really reflect the purpose of the field, but the terraform implementation instead. Since the implementation has changed in capi/capa, let's rename it so users don't expect the ignition object to not be destroyed when there are enough permissions.
The old field is kept for the deprecation period but will be removed in the future in favor of the new
BestEffortDeleteIgnition.