[release-4.15] OCPBUGS-35355: baremetal: Don't always enable provisioning-interface.service #8580
Conversation
…service In the baremetal bootstrap it is not sufficient to make ironic.service conditionally Require provisioning-interface.service, as 104eae1 attempted to do, when the latter is already enabled because it is WantedBy multi-user.target. As long as it is enabled, systemd will try to start it. Do not install provisioning-interface.service, so that it will only be enabled when ironic.service requires it (i.e. when the provisioning network is not disabled).
Similar to provisioning-interface.service, we don't always want to start ironic-dnsmasq.service. Remove it from multi-user.target's Wanted list, so that it is enabled only if ironic requests it.
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-35235 has been cloned as Jira Issue OCPBUGS-35355. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/severity-critical
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-35355, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
openshift-ci
bot
added
the
backport-risk-assessed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
/lgtm |
|
/jira refresh |
openshift-ci-robot
added
the
jira/valid-bug
|
@dtantsur: This pull request references Jira Issue OCPBUGS-35355, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
removed
the
jira/invalid-bug
openshift-merge-bot
bot
merged commit 75f3bf0
into
openshift:release-4.15
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-35355: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-35355 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-installer-altinfra-container-v4.15.0-202406131407.p0.g75f3bf0.assembly.stream.el8 for distgit ose-installer-altinfra. |
|
Fix included in accepted release 4.15.0-0.nightly-2024-06-13-204333 |
This is an automated cherry-pick of #8563
/assign hroyrh