pkg/asset/cluster: Don't read empty-string state files #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
openshift-ci-robot
added
the
approved
staebler
suggested changes
Dec 20, 2018
wking
force-pushed
the
ignore-tfstate-load-on-empty-path
branch
2 times, most recently
from
bffc929
to
68e550f
Compare
Avoid the confusing: ERROR Failed to read tfstate: open : no such file or directory and backing syscall when terraform.Apply returns an empty string. We're not exiting immediately on Apply errors (and are instead attempting to recover the Terraform state regardless of Apply errors) since 78c3118 (pkg: add ClusterMetadata asset,type that can be used for destroy, 2018-09-25, openshift#324). The goal there is to retain the current resource state in case the user wants to investigate the resources associated with the partially-launched cluster and potentially invoke Terraform themselves to finish the install instead of deleting and re-creating their cluster. Apply can return an empty-string state file since 3f4fe57 (cmd/openshift-install: Add 'destroy bootstrap' command, 2018-10-18, leave the temporary directory without a terraform state file. And we don't care about recovering the state file in those cases, because we haven't created any external resources at that point (before the apply call). Also flatten some unnecessary nesting in the err2 handling by using an 'else if' clause.
wking
force-pushed
the
ignore-tfstate-load-on-empty-path
branch
from
68e550f
to
9d30577
Compare
|
All the tests that matter are green :). |
|
/lgtm |
staebler
approved these changes
Feb 5, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: staebler, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Looks like e2e-aws 3446 succeeded, so... /refresh |
|
Ah, well. Giving up on job 3446... /test e2e-aws |
|
/test e2e-aws |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid the confusing:
and backing syscall when
terraform.Applyreturns an empty string.