Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-19008: Always add ignition to set hostname on /etc/hostname #106

Merged
merged 1 commit into from Jan 31, 2024

Conversation

derekhiggins
Copy link

Regardless of how IPA got to the point of finding a hostname we need it to match the hostname after its provisioned.

Regardless of how IPA got to the point of finding a hostname
we need it to match the hostname after its provisioned.
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 25, 2024
@openshift-ci-robot
Copy link

@derekhiggins: This pull request references Jira Issue OCPBUGS-19008, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jhajyahy@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Regardless of how IPA got to the point of finding a hostname we need it to match the hostname after its provisioned.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Jan 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekhiggins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2024
@derekhiggins
Copy link
Author

/retest-required

@derekhiggins
Copy link
Author

/test e2e-metal-ipi-ovn-ipv6

Copy link

openshift-ci bot commented Jan 26, 2024

@derekhiggins: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@derekhiggins
Copy link
Author

cc @dtantsur
As far as I can see the ignition wasn't being added because the dispatch script (added by image customisation) had already set the hostname

@dtantsur
Copy link
Member

/cc @zaneb

@openshift-ci openshift-ci bot requested a review from zaneb January 31, 2024 12:33
@dtantsur
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit a14b7ea into openshift:main Jan 31, 2024
9 checks passed
@openshift-ci-robot
Copy link

@derekhiggins: Jira Issue OCPBUGS-19008: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-19008 has been moved to the MODIFIED state.

In response to this:

Regardless of how IPA got to the point of finding a hostname we need it to match the hostname after its provisioned.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@derekhiggins
Copy link
Author

/cherrypick release-4.15

@openshift-cherrypick-robot

@derekhiggins: new pull request created: #108

In response to this:

/cherrypick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ironic-agent-container-v4.16.0-202401311812.p0.ga14b7ea.assembly.stream for distgit ironic-agent.
All builds following this will include this PR.

@openshift-merge-robot
Copy link

Fix included in accepted release 4.16.0-0.nightly-2024-02-02-002725

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants