Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.12] OCPBUGS-29769: Always add ignition to set hostname on /etc/hostname #112

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #111

/assign derekhiggins

Regardless of how IPA got to the point of finding a hostname
we need it to match the hostname after its provisioned.
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-29725 has been cloned as Jira Issue OCPBUGS-29769. Will retitle bug to link to clone.
/retitle [release-4.12] OCPBUGS-29769: Always add ignition to set hostname on /etc/hostname

In response to this:

This is an automated cherry-pick of #111

/assign derekhiggins

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.12] OCPBUGS-29725: Always add ignition to set hostname on /etc/hostname [release-4.12] OCPBUGS-29769: Always add ignition to set hostname on /etc/hostname Feb 21, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 21, 2024
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-29769, which is invalid:

  • expected dependent Jira Issue OCPBUGS-29725 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #111

/assign derekhiggins

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@derekhiggins
Copy link

/test e2e-metal-ipi-ovn-ipv6

1 similar comment
@derekhiggins
Copy link

/test e2e-metal-ipi-ovn-ipv6

@derekhiggins
Copy link

/retest

@derekhiggins
Copy link

/test e2e-metal-ipi-serial-ipv4

@elfosardo elfosardo added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 22, 2024
@elfosardo
Copy link

/approve

Copy link

openshift-ci bot commented Feb 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2024
@derekhiggins
Copy link

/test e2e-metal-ipi-serial-ipv4

@dtantsur
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2024
@derekhiggins
Copy link

/test e2e-metal-ipi-serial-ipv4

Copy link

openshift-ci bot commented Feb 26, 2024

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@derekhiggins
Copy link

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Feb 26, 2024
@openshift-ci-robot
Copy link

@derekhiggins: This pull request references Jira Issue OCPBUGS-29769, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-29725 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-29725 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jhajyahy@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 26, 2024
@jadhaj
Copy link

jadhaj commented Feb 26, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 26, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 38fe5bb into openshift:release-4.12 Feb 26, 2024
10 checks passed
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-29769: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29769 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #111

/assign derekhiggins

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ironic-agent-container-v4.12.0-202402261808.p0.g38fe5bb.assembly.stream.el9 for distgit ironic-agent.
All builds following this will include this PR.

@openshift-merge-robot
Copy link

Fix included in accepted release 4.12.0-0.nightly-2024-02-29-042809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants