Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-33452: update ironic-lib with latest fixes #133

Merged
merged 1 commit into from
May 10, 2024

Conversation

tdomnesc
Copy link

@tdomnesc tdomnesc commented May 9, 2024

bring in fix for 4096 bytes sector disks

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels May 9, 2024
@openshift-ci-robot
Copy link

@tdomnesc: This pull request references Jira Issue OCPBUGS-33452, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-33133 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-33133 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0, 4.15.z
  • bug has dependents

Requesting review from QA contact:
/cc @jadhaj

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

bring in fix for 4096 bytes sector disks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 9, 2024
@openshift-ci openshift-ci bot requested review from jadhaj, dtantsur and zaneb May 9, 2024 14:32
@tdomnesc
Copy link
Author

/retest-required

@tdomnesc
Copy link
Author

/test e2e-metal-ipi-bm

Copy link

openshift-ci bot commented May 10, 2024

@tdomnesc: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rhjanders
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2024
@derekhiggins
Copy link

/approve

Copy link

openshift-ci bot commented May 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekhiggins, tdomnesc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2024
@pamoedom
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 10, 2024
@iurygregory iurygregory added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 10, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 7e82a52 into openshift:release-4.14 May 10, 2024
9 checks passed
@openshift-ci-robot
Copy link

@tdomnesc: Jira Issue OCPBUGS-33452: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33452 has been moved to the MODIFIED state.

In response to this:

bring in fix for 4096 bytes sector disks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tdomnesc tdomnesc deleted the OCPBUGS-33452 branch May 10, 2024 16:07
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ironic-agent-container-v4.14.0-202405101907.p0.g7e82a52.assembly.stream.el9 for distgit ironic-agent.
All builds following this will include this PR.

@openshift-merge-robot
Copy link

Fix included in accepted release 4.14.0-0.nightly-2024-05-10-212837

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants