Merge from metal3-io #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite what oslo.log has in its code and documents, it uses underscores, not dashes.
Default to using --copy-network
Apply local patches before removing git
There is no need to have the same owners both under reviewers and approvers. Approvers always takes the precedence over reviewers.
Fix the log_file option name
Run efibootmgr if boot mode is UEFI
Remove redundancy in OWNERS
Leaving the following files intact: - Dockerfile.ocp - Dockerfile.okd - OWNERS - README.md
openshift-ci
bot
added
the
approved
|
/cc @hardys This includes the upstream work, especially the UEFI change |
iurygregory
approved these changes
Nov 3, 2021
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur, iurygregory The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaving the following files intact:
Commits included: