Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-19006: backport hostname fixes #89

Merged
merged 2 commits into from Sep 26, 2023
Merged

OCPBUGS-19006: backport hostname fixes #89

merged 2 commits into from Sep 26, 2023

Conversation

dtantsur
Copy link
Member

@dtantsur dtantsur commented Sep 15, 2023 •
edited

  • OCPBUGS-9072: Pass hostname within the ignition to coreos-installer
  • OCPBUGS-17372: fallback to /etc/hostname if hostnamectl fails

Depends on:

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 15, 2023
@openshift-ci-robot
Copy link

@dtantsur: This pull request references Jira Issue OCPBUGS-19006, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-9072 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-9072 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jhajyahy@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

  • OCPBUGS-9072: Pass hostname within the ignition to coreos-installer
  • OCPBUGS-17372: fallback to /etc/hostname if hostnamectl fails

Depends on:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Sep 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2023
@openshift-ci-robot
Copy link

@dtantsur: This pull request references Jira Issue OCPBUGS-19006, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-9072 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-9072 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jhajyahy@redhat.com), skipping review request.

In response to this:

  • OCPBUGS-9072: Pass hostname within the ignition to coreos-installer
  • OCPBUGS-17372: fallback to /etc/hostname if hostnamectl fails

Depends on:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dtantsur
Copy link
Member Author

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 15, 2023
@derekhiggins
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2023
@dtantsur
Copy link
Member Author

/retest

@openshift-ci-robot openshift-ci-robot mentioned this pull request Sep 19, 2023
Merged
@dtantsur
Copy link
Member Author

/retest

3 similar comments
@dtantsur
Copy link
Member Author

/retest

@dtantsur
Copy link
Member Author

/retest

@dtantsur
Copy link
Member Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Sep 26, 2023

@dtantsur: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jadhaj
Copy link

jadhaj commented Sep 26, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 26, 2023
@openshift-merge-robot openshift-merge-robot merged commit 508e612 into openshift:release-4.13 Sep 26, 2023
10 checks passed
@openshift-ci-robot
Copy link

@dtantsur: Jira Issue OCPBUGS-19006: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-19006 has been moved to the MODIFIED state.

In response to this:

  • OCPBUGS-9072: Pass hostname within the ignition to coreos-installer
  • OCPBUGS-17372: fallback to /etc/hostname if hostnamectl fails

Depends on:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dtantsur dtantsur deleted the OCPBUGS-19006 branch September 26, 2023 18:39
@openshift-merge-robot
Copy link

Fix included in accepted release 4.13.0-0.nightly-2023-09-27-193040

@dtantsur
Copy link
Member Author

dtantsur commented Oct 5, 2023

/cherry-pick release-4.12

@openshift-cherrypick-robot
Copy link

@dtantsur: new pull request created: #90

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 5, 2023
Merged
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ironic-agent-container-v4.13.0-202311210930.p0.g508e612.assembly.stream for distgit ironic-agent.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfournie bfournie Awaiting requested review from bfournie

@derekhiggins derekhiggins Awaiting requested review from derekhiggins

Assignees

@derekhiggins derekhiggins

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dtantsur @openshift-ci-robot @derekhiggins @jadhaj @openshift-merge-robot @openshift-cherrypick-robot @openshift-bot