Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove chmod command in Dockerfile #53

Merged
merged 1 commit into from Dec 10, 2020

Conversation

elfosardo
Copy link

The script is already executable, when it's copied to the container
should maintain the original execute bit.

Also changing COPY scripts to explicitly use * to deal with
imagebuilder limitations.

(cherry picked from commit 461a64d)

The script is already executable, when it's copied to the container
should maintain the original execute bit.

Also changing COPY scripts to explicitly use * to deal with
imagebuilder limitations.

(cherry picked from commit 461a64d)
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2020
@elfosardo
Copy link
Author

/test e2e-metal-ipi

Dockerfile.ocp Show resolved Hide resolved
@elfosardo
Copy link
Author

/test e2e-metal-ipi

@elfosardo elfosardo requested a review from zaneb December 9, 2020 16:49
Copy link
Member

@zaneb zaneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Dockerfile.ocp Show resolved Hide resolved
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@elfosardo
Copy link
Author

/test e2e-metal-ipi

@elfosardo elfosardo requested a review from zaneb December 10, 2020 08:24
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@elfosardo
Copy link
Author

Error: unable to pull virthost.ostest.test.metalkube.org:5000/localimages/local-release-image:4.7.0-0.ci.test-2020-12-10-100120-ci-op-qsr17wvc-ironic: Error initializing source docker://virthost.ostest.test.metalkube.org:5000/localimages/local-release-image:4.7.0-0.ci.test-2020-12-10-100120-ci-op-qsr17wvc-ironic: Error reading manifest 4.7.0-0.ci.test-2020-12-10-100120-ci-op-qsr17wvc-ironic in virthost.ostest.test.metalkube.org:5000/localimages/local-release-image: unauthorized: authentication required

doesn't look related to the patch, and I'm not able to reproduce this locally :/

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 1b4df25 into openshift:master Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants