New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove chmod command in Dockerfile #53
Conversation
The script is already executable, when it's copied to the container should maintain the original execute bit. Also changing COPY scripts to explicitly use * to deal with imagebuilder limitations. (cherry picked from commit 461a64d)
/test e2e-metal-ipi |
/test e2e-metal-ipi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elfosardo, zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
7 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/test e2e-metal-ipi |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
Error: unable to pull virthost.ostest.test.metalkube.org:5000/localimages/local-release-image:4.7.0-0.ci.test-2020-12-10-100120-ci-op-qsr17wvc-ironic: Error initializing source docker://virthost.ostest.test.metalkube.org:5000/localimages/local-release-image:4.7.0-0.ci.test-2020-12-10-100120-ci-op-qsr17wvc-ironic: Error reading manifest 4.7.0-0.ci.test-2020-12-10-100120-ci-op-qsr17wvc-ironic in virthost.ostest.test.metalkube.org:5000/localimages/local-release-image: unauthorized: authentication required doesn't look related to the patch, and I'm not able to reproduce this locally :/ |
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
The script is already executable, when it's copied to the container
should maintain the original execute bit.
Also changing COPY scripts to explicitly use * to deal with
imagebuilder limitations.
(cherry picked from commit 461a64d)