Introduce separate ARG for extra packages list #59
Conversation
openshift-ci-robot
added
approved
elfosardo
force-pushed
the
install-extra-pkgs-ocp
branch
from
21ab59e
to
2a38412
Compare
openshift-ci-robot
removed
the
needs-rebase
Convert the current PKGS_LIST to ENV as we should not really touch it. Introduce the EXTRA_PKGS_LIST ARG to allow specifying a file containing a list of extra packages to install. The goal is to allow installing packages from different sources to test them.
elfosardo
force-pushed
the
install-extra-pkgs-ocp
branch
from
2a38412
to
aef1b92
Compare
elfosardo
requested review from
derekhiggins,
hardys,
stbenjam,
bfournie,
iurygregory and
dtantsur
|
Does this need to be updated to match the upstream PR? |
|
++ I think it should match the upstream PR |
|
@stbenjam @iurygregory I'm not seeing the difference except for PATCH_LIST that is not supposed to be here anyway as it's not supported (on purpose) |
Oh I see =) |
|
|
||
| dnf upgrade -y | ||
| xargs -rd'\n' dnf --setopt=install_weak_deps=False install -y < /tmp/main-packages-list.txt | ||
| xargs -rtd'\n' dnf --setopt=install_weak_deps=False install -y < /tmp/${PKGS_LIST} | ||
| if [[ ! -z ${EXTRA_PKGS_LIST:-} ]]; then |
There was a problem hiding this comment.
It cannot be empty, it has a default value.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur, elfosardo, iurygregory The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Convert the current PKGS_LIST to ENV as we should not really touch it.
Introduce the EXTRA_PKGS_LIST ARG to allow specifying a file
containing a list of extra packages to install.
The goal is to allow installing packages from different sources
to test them.
metal3 ref metal3-io#72