Enable the use of a proxy to download images

[kirankt]

Even though HTTP(S)_PROXY variable(s) is exposed in the container, curl requires the use of (lowercase) http(s)_proxy variables to function properly. This patch will enable curl to download images via a proxy.

[openshift-ci-robot]

Hi @kirankt. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[stbenjam]

/ok-to-test

[stbenjam]

/lgtm
/assign @elfosardo could you take a look?

[stbenjam]

@kirankt Also, it would be a good idea to have this change in https://github.com/metal3-io/ironic-ipa-downloader, so both containers work the same way upstream and in openshift.

[stbenjam]

/lgtm

[stbenjam]

/assign @elfosardo

[kirankt]

@kirankt Also, it would be a good idea to have this change in https://github.com/metal3-io/ironic-ipa-downloader, so both containers work the same way upstream and in openshift.

Hi @stbenjam, If you meant in the rhcos-downloader, its already done: openshift/ironic-rhcos-downloader#22. Thanks.

[stbenjam]

@kirankt Also, it would be a good idea to have this change in metal3-io/ironic-ipa-downloader, so both containers work the same way upstream and in openshift.

Hi @stbenjam, If you meant in the rhcos-downloader, its already done: openshift/ironic-rhcos-downloader#22. Thanks.

Nope, I meant https://github.com/metal3-io/ironic-ipa-downloader - upstream metal3 project has it's own ironic-ipa-downloader repo, this one (openshift) is a fork of it. We should have a PR there to make sure openshift and metal3 are consistent

[kirankt]

@kirankt Also, it would be a good idea to have this change in metal3-io/ironic-ipa-downloader, so both containers work the same way upstream and in openshift.

Hi @stbenjam, If you meant in the rhcos-downloader, its already done: openshift/ironic-rhcos-downloader#22. Thanks.

Nope, I meant https://github.com/metal3-io/ironic-ipa-downloader - upstream metal3 project has it's own ironic-ipa-downloader repo, this one (openshift) is a fork of it. We should have a PR there to make sure openshift and metal3 are consistent

Ah. OK. Sorry I misread that one. Will send a PR ASAP.

[kirankt]

/retest

[elfosardo]

@kirankt @stbenjam this should be ok, unfortunately at the moment there's an issue with the CI so we can't really merge anything, yay :(
In the meantime please submit a PR to https://github.com/metal3-io/ironic-ipa-downloader with the same change so we can link that to this, thanks!

[kirankt]

@kirankt @stbenjam this should be ok, unfortunately at the moment there's an issue with the CI so we can't really merge anything, yay :(
In the meantime please submit a PR to https://github.com/metal3-io/ironic-ipa-downloader with the same change so we can link that to this, thanks!

Done. Thanks.
metal3-io#13

[hardys]

/retest

[hardys]

/lgtm

[hardys]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hardys, kirankt, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hardys]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment