Bug 1804128: Ramdisk arch should not be hardcoded #28
Conversation
Hardcoding is bad, don't do it kids.
elfosardo
requested review from
stbenjam,
dtantsur,
derekhiggins,
hardys,
juliakreger and
bfournie
openshift-ci-robot
added
size/XS
|
lgtm pending bz and images CI! |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: derekhiggins, elfosardo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
elfosardo
changed the title
|
@elfosardo: This pull request references Bugzilla bug 1804128, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
/bugzilla refresh |
|
@elfosardo: This pull request references Bugzilla bug 1804128, which is valid. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@elfosardo: All pull requests linked via external trackers have merged. Bugzilla bug 1804128 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The arch of the ramdisk should be determined based on the system we're running on, not hardcoded.
This will fix the issue with the latest failing 4.4 builds.