Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1894992: Add tenacity to installed packages, and hack eventlet to workaround a bug #47

Merged
merged 2 commits into from Nov 5, 2020
Merged

Bug 1894992: Add tenacity to installed packages, and hack eventlet to workaround a bug #47

merged 2 commits into from Nov 5, 2020

Conversation

stbenjam
Copy link
Member

@stbenjam stbenjam commented Nov 5, 2020 •
edited

Adds on to #46 to apply a hack for eventlet.

@elfosardo @stbenjam
Add tenacity lib to installed packages
8960f0d 
This is to prevent ironic-python-agent failure as the package is
currently missing from the specs.
@stbenjam stbenjam changed the title Temp: using this pr to get an openshift release I can test WIP: using this pr to get an openshift release I can test Nov 5, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 5, 2020
@stbenjam
Copy link
Member Author

stbenjam commented Nov 5, 2020

/test images

4 similar comments
@stbenjam
Copy link
Member Author

stbenjam commented Nov 5, 2020

/test images

@stbenjam
Copy link
Member Author

stbenjam commented Nov 5, 2020

/test images

@jupierce
Copy link

jupierce commented Nov 5, 2020

/test images

@jupierce
Copy link

jupierce commented Nov 5, 2020

/test images

@jupierce
Copy link

jupierce commented Nov 5, 2020

/test e2e-metal-ipi

@stbenjam
Copy link
Member Author

stbenjam commented Nov 5, 2020

Thanks I got what I needed from this :) I was just using this to get a release image built.

/close

@openshift-ci-robot
Copy link

@stbenjam: Closed this PR.

In response to this:

Thanks I got what I needed from this :) I was just using this to get a release image built.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam
Copy link
Member Author

stbenjam commented Nov 5, 2020

/reopen

@openshift-ci-robot
Copy link

@stbenjam: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam stbenjam changed the title WIP: using this pr to get an openshift release I can test Add tenacity to installed packages, and hack eventlet to workaround a bug Nov 5, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 5, 2020
@stbenjam
Copy link
Member Author

stbenjam commented Nov 5, 2020

Actually this PR might be the one to supersede #46 as additional fixes are needed.

@stbenjam
Copy link
Member Author

stbenjam commented Nov 5, 2020

/hold

Pending passing CI

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2020
dtantsur
dtantsur approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@dtantsur dtantsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 5, 2020
@stbenjam stbenjam changed the title Add tenacity to installed packages, and hack eventlet to workaround a bug Bug 1894992: Add tenacity to installed packages, and hack eventlet to workaround a bug Nov 5, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 5, 2020
@openshift-ci-robot
Copy link

@stbenjam: This pull request references Bugzilla bug 1894992, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1894992: Add tenacity to installed packages, and hack eventlet to workaround a bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam
Copy link
Member Author

stbenjam commented Nov 5, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link

@stbenjam: This pull request references Bugzilla bug 1894992, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 5, 2020
@stbenjam
Copy link
Member Author

stbenjam commented Nov 5, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 5, 2020
@openshift-merge-robot openshift-merge-robot merged commit 961dc8e into openshift:master Nov 5, 2020
@openshift-ci-robot
Copy link

@stbenjam: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1894992 has not been moved to the MODIFIED state.

In response to this:

Bug 1894992: Add tenacity to installed packages, and hack eventlet to workaround a bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam stbenjam deleted the temp branch November 5, 2020 20:37
@stbenjam stbenjam mentioned this pull request Nov 5, 2020
Closed
@stbenjam
Copy link
Member Author

stbenjam commented Nov 5, 2020

https://bugzilla.redhat.com/show_bug.cgi?id=1895109 tracks fixing eventlet

@elfosardo elfosardo mentioned this pull request Nov 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtantsur dtantsur dtantsur approved these changes

@dhellmann dhellmann Awaiting requested review from dhellmann

@elfosardo elfosardo Awaiting requested review from elfosardo

Assignees

@dtantsur dtantsur

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@stbenjam @jupierce @openshift-ci-robot @dtantsur @openshift-merge-robot @elfosardo