Bug 1899190: Apply hack to eventlet #53
Conversation
(cherry picked from commit f2bde94)
|
@elfosardo: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
approved
openshift-ci-robot
added
bugzilla/severity-high
|
@elfosardo: This pull request references Bugzilla bug 1899190, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@elfosardo: This pull request references Bugzilla bug 1899190, which is valid. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
elfosardo
requested review from
dtantsur,
stbenjam,
bfournie and
derekhiggins
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bfournie, dtantsur, elfosardo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
lgtm but for the benefit of the patch manager it's probably worth adding some more context to the PR description e.g the upstream bug reference and the version we expect to properly fix the issue |
|
@elfosardo: This pull request references Bugzilla bug 1899190, which is valid. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@hardys I've added some more info in the PR description |
@dtantsur we have already have the new eventlet tagged in ocp 4.6 but it's not being installed for some reason. The hack although works while I try to understand why the new eventlet is not being picked up. |
|
(patch manager) @elfosardo The main thing a patch manager is going to look for, especially when there's a backlog of PRs, is what the impact is. I've followed the trail to the bug where it has a vague reference to "get the most recent bugfixes" which is a bit shaky, are customers blocked on things without those fixes? Are they nice to have? |
|
@elfosardo is probably gone for the day, but IIRC this is a must-have. The broken eventlet makes baremetal IPI uninstallable in some (all?) cases. |
sdodson
added
the
cherry-pick-approved
|
@elfosardo: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 1899190 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sdodson I understand the confusion, apologies for that, I will do my best to be more precise in the future. Thanks for the approval |
|
/bugzilla refresh |
|
@stbenjam: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 1899190 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@stbenjam: Bugzilla bug 1899190 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@stbenjam No, this missed 4.6.7 which wrapped up last week, it will make whatever is after that. |
This hack has been applied to OCP 4.7 and it's backported to 4.6 as we're seeing the same issue with SSL failing with ssl.SSLWantReadError
For more info please check eventlet/eventlet#308
(cherry picked from commit f2bde94)