Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add xz support for FCOS #15

Merged
merged 1 commit into from Nov 20, 2019
Merged

Add xz support for FCOS #15

merged 1 commit into from Nov 20, 2019

Conversation

hardys
Copy link
Contributor

@hardys hardys commented Nov 20, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 20, 2019
@hardys
Copy link
Contributor Author

hardys commented Nov 20, 2019

/cc @elfosardo @vrutkovs FYI

We'll also have to fix the variable and symlink names to remote the rhcos naming, but that will require changes to the installer/MAO so I'll take a look at that as a follow-up.

@openshift-ci-robot
Copy link
Contributor

@hardys: GitHub didn't allow me to request PR reviews from the following users: FYI.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @elfosardo @vrutkovs FYI

We'll also have to fix the variable and symlink names to remote the rhcos naming, but that will require changes to the installer/MAO so I'll take a look at that as a follow-up.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vrutkovs
vrutkovs approved these changes Nov 20, 2019
View reviewed changes
Copy link
Member

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elfosardo
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, hardys, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit bc561b8 into openshift:master Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrutkovs vrutkovs vrutkovs approved these changes

@bfournie bfournie Awaiting requested review from bfournie

@derekhiggins derekhiggins Awaiting requested review from derekhiggins

@elfosardo elfosardo Awaiting requested review from elfosardo

Assignees

@elfosardo elfosardo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hardys @openshift-ci-robot @elfosardo @vrutkovs @openshift-merge-robot