Merge openshift #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The URL provided internally by the installer is the full path to the openstack qcow file, and the baseURI is supposed to be an internal detail, so we need to handle this case for the planned switch to use installer generated image references: openshift/installer#2037 openshift/installer#2061 The previous baseURI method is maintained for backwards compatibilty and can be removed later when the installer changes are complete, and at that point we probably want to remove the latest symlinks as I think we need to deal with explicit image references in the providerSpec, then have the BMO (and terraform) look at the mirror location for the locally downloaded/compressed version.
Handle a fully-qualified openstack qcow URL
openshift-ci-robot
added
the
size/S
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.