Fixed the issue of duplicate pipeline #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, when the buildconfig name is different then git repo name then sync plugin is not able to find buildconfig by repo name while syncing back to openshift after creating a buildconfig with strategy JenkinsPipeline, and create a new buildconfig repo name, To fix this issue, added a label of gitRepository name so it will first try to find the BuildConfig with name of jenkins job, if that is not present that is our case then it will also try to find the buildconfig having label with the name of jenkins job and then if it is not present will create a new BuildConfig openshift#27 Declared constant variable for label key Removed NPE and added comments in the code to always know the context behind this
openshift-ci-robot
added
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@gabemontero: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
akram
pushed a commit
to akram/jenkins-sync-plugin
that referenced
this pull request
Aug 1, 2019
* Fixed the issue of duplicate pipeline Right now, when the buildconfig name is different then git repo name then sync plugin is not able to find buildconfig by repo name while syncing back to openshift after creating a buildconfig with strategy JenkinsPipeline, and create a new buildconfig repo name, To fix this issue, added a label of gitRepository name so it will first try to find the BuildConfig with name of jenkins job, if that is not present that is our case then it will also try to find the buildconfig having label with the name of jenkins job and then if it is not present will create a new BuildConfig #27 Declared constant variable for label key Removed NPE and added comments in the code to always know the context behind this * Updated wrong logging in #28 PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, when the buildconfig name is different then git repo name
then sync plugin is not able to find buildconfig by repo name while
syncing back to openshift after creating a buildconfig with strategy
JenkinsPipeline, and create a new buildconfig repo name, To fix this
issue, added a label of gitRepository name so it will first try to
find the BuildConfig with name of jenkins job, if that is not present
that is our case then it will also try to find the buildconfig having
label with the name of jenkins job and then if it is not present will
create a new BuildConfig #27
Declared constant variable for label key
Removed NPE and added comments in the code to always know the context behind this
cherry-pick of fabric8io#28 , as well as some space/tab issues
@openshift/sig-developer-experience @piyush1594 fyi/ptal