Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHDEVDOCS-3941 Replace plugin with plug-in #421

Merged
merged 1 commit into from
Apr 6, 2022
Merged

RHDEVDOCS-3941 Replace plugin with plug-in #421

merged 1 commit into from
Apr 6, 2022

Conversation

rolfedh
Copy link

@rolfedh rolfedh commented Apr 5, 2022

Aligned team: Dev Tools

@openshift-ci openshift-ci bot requested review from akram and sbose78 April 5, 2022 19:51
akram
akram suggested changes Apr 6, 2022
View reviewed changes
Copy link

@akram akram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the README.md in the vendor directory must not be changed.
vendor files must be kept untouched as they are automatically injected from go lang source dependency management.
can you please revert this one?

Apart from that, all the rest lgtm.

@akram
Copy link

akram commented Apr 6, 2022

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 6, 2022
@akram
Copy link

akram commented Apr 6, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Apr 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akram, rolfedh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akram
Copy link

akram commented Apr 6, 2022

/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Apr 6, 2022
@akram
Copy link

akram commented Apr 6, 2022

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 6, 2022
@openshift-bot
Copy link

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link

openshift-ci bot commented Apr 6, 2022

@rolfedh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit e006d80 into openshift:master Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akram akram akram requested changes

@sbose78 sbose78 Awaiting requested review from sbose78

Assignees

@akram akram

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rolfedh @akram @openshift-bot @openshift-merge-robot