New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1971537: Support cgroups v2 #1019
Bug 1971537: Support cgroups v2 #1019
Conversation
/assign @akashshinde |
/unassign akashshinde |
/assign |
@waveywaves, just to clarify I understand, do you mean this will be postponed and addressed as a part of some larger effort later? I am asking to set some expectation on when this can get integrated. Thanks! |
88831a0
to
f94b734
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cardil The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thanks @cardil for this contribution. We need more time to test it ; as it seem non-intrusive for OpenShift, it could be merged hopefully. |
/retitle [main] Support cgroups v2 (Podman on Fedora 31) |
/retitle [head] Support cgroups v2 (Podman on Fedora 31) |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
/remove-lifecycle rotten |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akram, cardil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retitle Bug 1971537: Support cgroups v2 |
@cardil: This pull request references Bugzilla bug 1971537, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
@openshift-bot: This pull request references Bugzilla bug 1971537, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@akram: This pull request references Bugzilla bug 1971537, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/test images |
/retest Please review the full test history for this PR and help us cut down flakes. |
@cardil: All pull requests linked via external trackers have merged: Bugzilla bug 1971537 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In code there are embedded paths that are valid only for cgroups v1. This PR creates functions that calculate memory in container either for v1 or v2 of cgroups.