Bug 1820677: Update Description on Monitored Templates reflecting permission issues #1046
Conversation
To create the Service Monitor custom resource in the Templates, provided by the Prometheus Operator in Openshift, users needs specific RBAC permissions to be able to create them. This necessity needs to be understood by them, hence adding this to the description of the templates.
|
@waveywaves: This pull request references Bugzilla bug 1820677, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
openshift-ci-robot
added
the
approved
|
/bugzilla refresh |
|
@waveywaves: This pull request references Bugzilla bug 1820677, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/valid-bug
|
@waveywaves: This pull request references Bugzilla bug 1820677, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @adambkaplan |
|
/bugzilla refresh |
|
@akram: This pull request references Bugzilla bug 1820677, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
I don't think this is sufficient - customers won't know which RBAC rules to create without trial and error.
I would add a separate doc or update the README to include an example RBAC role that grants permission to create service monitors, and then aggregates it to the admin and edit user roles.
|
@adambkaplan I will update accordingly then. Thanks for helping out on this. |
|
I updated the documentation here: we cannot directly reference the KCS article as we use also the templates for origin. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akram, waveywaves The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@waveywaves: All pull requests linked via external trackers have merged: openshift/jenkins#1046. Bugzilla bug 1820677 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
To create the Service Monitor custom resource in the Templates,
provided by the Prometheus Operator in Openshift,
users needs specific RBAC permissions to be able to create them.
This necessity needs to be understood by them, hence adding this to the
description of the templates.