Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1950175: Build with Go 1.16 #1246

Merged
merged 1 commit into from Apr 23, 2021
Merged

Bug 1950175: Build with Go 1.16 #1246

merged 1 commit into from Apr 23, 2021

Conversation

yselkowitz
Copy link
Contributor

Closes #1244, #1245

@yselkowitz
Copy link
Contributor Author

/retest

2 similar comments
@yselkowitz
Copy link
Contributor Author

/retest

@yselkowitz
Copy link
Contributor Author

/retest

@yselkowitz
Copy link
Contributor Author

CI failure appears unrelated.
/assign @sbose78

@yselkowitz
Copy link
Contributor Author

/retest

1 similar comment
@yselkowitz
Copy link
Contributor Author

/retest

@waveywaves
Copy link
Contributor

/retest

@yselkowitz I agree, they do seem unrelated

@yselkowitz
Copy link
Contributor Author

/retest

3 similar comments
@LorbusChris
Copy link
Member

/retest

@yselkowitz
Copy link
Contributor Author

/retest

@yselkowitz
Copy link
Contributor Author

/retest

@LorbusChris
Copy link
Member

there seems to be a problem with the AWS infra, not sure what's causing it.

msg=Error: error updating LB Target Group (arn:aws:elasticloadbalancing:us-east-1:460538899914:targetgroup/-f86ad-5b2b9-aext/3068e8521bb722ec) tags: error tagging resource (arn:aws:elasticloadbalancing:us-east-1:460538899914:targetgroup/-f86ad-5b2b9-aext/3068e8521bb722ec): TargetGroupNotFound: Target groups 'arn:aws:elasticloadbalancing:us-east-1:460538899914:targetgroup/**************-f86ad-5b2b9-aext/3068e8521bb722ec' not found

might be transient.
/retest

@yselkowitz
Copy link
Contributor Author

/retest

@yselkowitz
Copy link
Contributor Author

These images have not been built for over two weeks due to this.
/assign @bparees

@bparees
Copy link
Contributor

bparees commented Apr 9, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, yselkowitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2021
@yselkowitz
Copy link
Contributor Author

Failure looks completely unrelated to this PR:

Cluster accessed images that were not mirrored to the testing repository or already part of the cluster, see test/extended/util/image/README.md in the openshift/origin repo:

quay.io/redhat-developer/nfs-server:latest from pods:
  ns/e2e-test-jenkins-pipeline-7l227 pod/nfs-server node/ip-10-0-164-3.ec2.internal

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

17 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@LorbusChris
Copy link
Member

Blocked by openshift/origin#26088
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 20, 2021
@yselkowitz
Copy link
Contributor Author

nfs-server fix merged
/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 22ae286 into openshift:master Apr 23, 2021
@openshift-ci-robot
Copy link
Contributor

@yselkowitz: All pull requests linked via external trackers have merged:

Bugzilla bug 1950175 has been moved to the MODIFIED state.

In response to this:

Bug 1950175: Build with Go 1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkhelil jkhelil Awaiting requested review from jkhelil

@waveywaves waveywaves Awaiting requested review from waveywaves

@jitendar-singh jitendar-singh Awaiting requested review from jitendar-singh

Assignees

@sbose78 sbose78

@bparees bparees

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@yselkowitz @waveywaves @LorbusChris @bparees @openshift-ci-robot @openshift-bot @sbose78 @openshift-merge-robot