New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nuke custom credentials for kubernetes-plugin #1268
Nuke custom credentials for kubernetes-plugin #1268
Conversation
This is no longer necessary in recent versions of the plugin and it causes problems because if a user is using configuration-as-code to define their own credentials, it will overwrite our changes and the kubernetes plugin will get confused trying to use it. See: https://bugzilla.redhat.com/show_bug.cgi?id=1956652 See: https://access.redhat.com/solutions/6016001
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jlebon The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
(Totally untested.) |
ab78cf7
to
cd732e9
Compare
/retest |
/test e2e-aws-jenkins |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jkhelil, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jkhelil: Overrode contexts on behalf of jkhelil: ci/prow/e2e-aws, ci/prow/e2e-aws-jenkins In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override ci/prow/e2e-aws-jenkins |
@jkhelil: Overrode contexts on behalf of jkhelil: ci/prow/e2e-aws, ci/prow/e2e-aws-jenkins In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Nuke custom credentials for kubernetes-plugin
This is no longer necessary in recent versions of the plugin and it
causes problems because if a user is using configuration-as-code to
define their own credentials, it will overwrite our changes and the
kubernetes plugin will get confused trying to use it.
See: https://bugzilla.redhat.com/show_bug.cgi?id=1956652
See: https://access.redhat.com/solutions/6016001