Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuke custom credentials for kubernetes-plugin #1268

Merged
merged 1 commit into from Jun 18, 2021

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented May 4, 2021

This is no longer necessary in recent versions of the plugin and it
causes problems because if a user is using configuration-as-code to
define their own credentials, it will overwrite our changes and the
kubernetes plugin will get confused trying to use it.

See: https://bugzilla.redhat.com/show_bug.cgi?id=1956652
See: https://access.redhat.com/solutions/6016001

This is no longer necessary in recent versions of the plugin and it
causes problems because if a user is using configuration-as-code to
define their own credentials, it will overwrite our changes and the
kubernetes plugin will get confused trying to use it.

See: https://bugzilla.redhat.com/show_bug.cgi?id=1956652
See: https://access.redhat.com/solutions/6016001
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jlebon
To complete the pull request process, please assign bparees after the PR has been reviewed.
You can assign the PR to them by writing /assign @bparees in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jlebon
Copy link
Member Author

jlebon commented May 4, 2021

(Totally untested.)

@akram
Copy link
Contributor

akram commented May 5, 2021

/retest

@jkhelil
Copy link
Contributor

jkhelil commented Jun 8, 2021

/test e2e-aws-jenkins

@jkhelil
Copy link
Contributor

jkhelil commented Jun 17, 2021

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 17, 2021
@jkhelil
Copy link
Contributor

jkhelil commented Jun 17, 2021

/lgtm
/override ci/prow/e2e-aws-jenkins
/override ci/prow/e2e-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkhelil, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 17, 2021

@jkhelil: Overrode contexts on behalf of jkhelil: ci/prow/e2e-aws, ci/prow/e2e-aws-jenkins

In response to this:

/lgtm
/override ci/prow/e2e-aws-jenkins
/override ci/prow/e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jkhelil
Copy link
Contributor

jkhelil commented Jun 18, 2021

/override ci/prow/e2e-aws-jenkins
/override ci/prow/e2e-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 18, 2021

@jkhelil: Overrode contexts on behalf of jkhelil: ci/prow/e2e-aws, ci/prow/e2e-aws-jenkins

In response to this:

/override ci/prow/e2e-aws-jenkins
/override ci/prow/e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit d2a28a5 into openshift:master Jun 18, 2021
adambkaplan pushed a commit to adambkaplan/jenkins that referenced this pull request Oct 1, 2021
Nuke custom credentials for kubernetes-plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants