Bug 1972451: Correctly declare Jenkins URL with trailing slash

[olivergondza]

This is normally enforced by Jenkins itself, though since this is injected through direct modification of the XML file, the incorrect version stays in. There are rare situations when plugins do not expect the values does not adhere to invariants imposed by Jenkins and fail when run in OpenShift:

https://github.com/jenkinsci/jenkins/blob/a1175b932e1ac97085d69752f5821141d012314f/core/src/main/java/jenkins/model/JenkinsLocationConfiguration.java#L144

[openshift-ci]

Hi @olivergondza. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[waveywaves]

/ok-to-test

[jkhelil]

/test e2e-aws

[akram]

/lgtm

[akram]

/retitle Bug 1972451: Correctly declare Jenkins URL with trailing slash

[openshift-ci]

@olivergondza: This pull request references Bugzilla bug 1972451, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jitendar-singh

In response to this:

Bug 1972451: Correctly declare Jenkins URL with trailing slash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[olivergondza]

Can you guys please take a look at the tests? From the little I understand about the test output, it seems unrelated. Thanks for any pointers!

[jkhelil]

/override ci/prow/e2e-aws-jenkins

[jkhelil]

/lgtm

[openshift-ci]

@jkhelil: Overrode contexts on behalf of jkhelil: ci/prow/e2e-aws-jenkins

In response to this:

/override ci/prow/e2e-aws-jenkins

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jkhelil]

/lgtm
/override ci/prow/e2e-aws-jenkins
/override ci/prow/e2e-aws

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akram, jkhelil, olivergondza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [akram,jkhelil]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jkhelil: Overrode contexts on behalf of jkhelil: ci/prow/e2e-aws, ci/prow/e2e-aws-jenkins

In response to this:

/lgtm
/override ci/prow/e2e-aws-jenkins
/override ci/prow/e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci]

@olivergondza: All pull requests linked via external trackers have merged:

• openshift/jenkins#1269

Bugzilla bug 1972451 has been moved to the MODIFIED state.

In response to this:

Bug 1972451: Correctly declare Jenkins URL with trailing slash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.