Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move call to create_jenkins_location_configuration_xml after image_co… #1291

Merged
merged 1 commit into from Jun 22, 2021
Merged

Move call to create_jenkins_location_configuration_xml after image_co… #1291

merged 1 commit into from Jun 22, 2021

Conversation

akram
Copy link
Contributor

@akram akram commented Jun 17, 2021

Move call to create_jenkins_location_configuration_xml after image_config_dir init
Fixes #1191

@openshift-ci openshift-ci bot requested review from jkhelil and otaviof June 17, 2021 16:14
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2021
@akram akram force-pushed the 4.9-fix-image-config-dir branch 9 times, most recently from c695978 to 330b37a Compare June 18, 2021 05:23
@akram
Copy link
Contributor Author

akram commented Jun 18, 2021

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_jenkins/1291/pull-ci-openshift-jenkins-master-e2e-aws/1405758211218214912

flakes on prometheus and 3/2860 Tests failed.

/override ci/prow/e2e-aws

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 18, 2021

@akram: Overrode contexts on behalf of akram: ci/prow/e2e-aws

In response to this:

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_jenkins/1291/pull-ci-openshift-jenkins-master-e2e-aws/1405758211218214912

flakes on prometheus and 3/2860 Tests failed.

/override ci/prow/e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jkhelil
Copy link
Contributor

jkhelil commented Jun 18, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2021
@akram
Copy link
Contributor Author

akram commented Jun 18, 2021

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 20, 2021

@akram: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 20, 2021
@akram
Copy link
Contributor Author

akram commented Jun 21, 2021

/refresh

@akram
Copy link
Contributor Author

akram commented Jun 21, 2021

/remove-label needs-rebase

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2021

@akram: The label(s) /remove-label needs-rebase cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed

In response to this:

/remove-label needs-rebase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akram
Copy link
Contributor Author

akram commented Jun 21, 2021

/retest

@akram
Copy link
Contributor Author

akram commented Jun 21, 2021

1/2600+ tests failed ...argh...

level=warning msg=DependencyViolation: The dhcpOptions 'dopt-070dcb11a619de43a' has dependencies and cannot be deleted. arn=arn:aws:ec2:us-east-1:460538899914:dhcp-options/dopt-070dcb11a619de43a
level=warning msg=	status code: 400, request id: a417084d-7146-4bcc-b74e-ee765b708290 arn=arn:aws:ec2:us-east-1:460538899914:dhcp-options/dopt-070dcb11a619de43a
level=info msg=Released id=eipalloc-08ce9fe037839159e

and this was when deallocating the cluster. flake flake

/retest

@jkhelil
Copy link
Contributor

jkhelil commented Jun 22, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akram, jkhelil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@waveywaves
Copy link
Contributor

/needs-rebase cancel

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 22, 2021
@openshift-merge-robot openshift-merge-robot merged commit 15df374 into openshift:master Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkhelil jkhelil Awaiting requested review from jkhelil

@otaviof otaviof Awaiting requested review from otaviof

Assignees

@jkhelil jkhelil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bad usage of ${image_config_dir} in /usr/libexec/s2i/run
5 participants
@akram @jkhelil @openshift-bot @waveywaves @openshift-merge-robot