Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring template based install test #1299

Merged

Conversation

jitendar-singh
Copy link
Contributor

  • Refactoring test for jenkins ephemeral template based install
  • Refactoring test for agent maven
  • Refactoring test for agent nodejs
  • Updating the README.MD
  • Adding smoke as a PHONY target in the Makefile, so that we can run the test using " make smoke "
  • Adding samples/maven_pipeline & samples/nodejs_pipeline to test the agent images
  • Adding a scripts folder with test-jenkins-template-install.sh which provisions the test environment

@openshift-ci openshift-ci bot requested review from sbose78 and waveywaves July 2, 2021 05:03
@jkhelil
Copy link
Contributor

jkhelil commented Jul 2, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jitendar-singh, jkhelil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2021
@openshift-merge-robot openshift-merge-robot merged commit d239321 into openshift:master Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants