-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding persistent template test and updating some #1302
Merged
openshift-merge-robot
merged 1 commit into
openshift:master
from
jitendar-singh:plugins-test
Jul 9, 2021
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
Feature: Testing jenkins agent maven image | ||
|
||
As a user of Jenkins on openshift | ||
I want to deploy JavaEE application on OpenShift | ||
|
||
|
||
Background: | ||
Given Project [TEST_NAMESPACE] is used | ||
|
||
Scenario: Deploy JavaEE application on OpenShift | ||
Given The jenkins pod is up and runnning | ||
When The user create objects from the sample maven template by processing the template and piping the output to oc create | ||
And verify imagestream.image.openshift.io/openshift-jee-sample & imagestream.image.openshift.io/wildfly exist | ||
And verify buildconfig.build.openshift.io/openshift-jee-sample & buildconfig.build.openshift.io/openshift-jee-sample-docker exist | ||
And verify deploymentconfig.apps.openshift.io/openshift-jee-sample is created | ||
And verify service/openshift-jee-sample is created | ||
And verify route.route.openshift.io/openshift-jee-sample is created | ||
Then Trigger the build using oc start-build openshift-jee-sample | ||
Then verify the build status of openshift-jee-sample-docker build is Complete | ||
And verify the build status of openshift-jee-sample-1 is Complete | ||
And verify the JaveEE application is accessible via route openshift-jee-sample |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
Feature: Testing jenkins agent nodejs image | ||
|
||
As a user of Jenkins on openshift | ||
I want to deploy Nodejs application on OpenShift | ||
|
||
|
||
Background: | ||
Given Project [TEST_NAMESPACE] is used | ||
|
||
Scenario: Deploy sample application on openshift | ||
Given The jenkins pod is up and runnning | ||
When The user enters new-app command with nodejs_template | ||
Then Trigger the build using oc start-build | ||
Then nodejs-postgresql-example pod must come up | ||
And route nodejs-postgresql-example must be created and be accessible |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
Feature: Delete all resources created using jenkins ephemeral template | ||
|
||
We want to delete the resources created using jenkins ephemeral template | ||
We want this to continue in the same namespace & start testing the jenkins persistent template based install | ||
|
||
Background: | ||
Given Project [TEST_NAMESPACE] is used | ||
|
||
Scenario: Delete all resources | ||
Given we have a openshift cluster | ||
Then we delete deploymentconfig.apps.openshift.io "jenkins" | ||
And we delete route.route.openshift.io "jenkins" | ||
And delete configmap "jenkins-trusted-ca-bundle" | ||
And delete serviceaccount "jenkins" | ||
And delete rolebinding.authorization.openshift.io "jenkins_edit" | ||
And delete service "jenkins-jnlp" | ||
And delete service "jenkins" | ||
And delete all buildconfigs | ||
And delete all builds | ||
And delete all build pods | ||
And delete all deploymentconfig |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
Feature: Deploy Jenkins with persistent volume on openshift using template based install | ||
|
||
As a user of openshift | ||
I want to deploy Jenkins with persistent volume and configure my CI/CD on openshift cluster | ||
|
||
Background: | ||
Given Project [TEST_NAMESPACE] is used | ||
|
||
Scenario: Create jenkins using persistent template | ||
Given we have a openshift cluster | ||
When User enters oc new-app jenkins-persistent command | ||
Then route.route.openshift.io "jenkins" created | ||
And configmap "jenkins-trusted-ca-bundle" created | ||
And persistentvolumeclaim "jenkins" created | ||
Then we check the pvc status is "Bound" | ||
And deploymentconfig.apps.openshift.io "jenkins" created | ||
And serviceaccount "jenkins" created | ||
And rolebinding.authorization.openshift.io "jenkins_edit" created | ||
And service "jenkins-jnlp" created | ||
And service "jenkins" created | ||
Then We check for deployment pod status to be "Completed" | ||
And We check for jenkins master pod status to be "Ready" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
Feature: Testing jenkins agent maven image | ||
|
||
As a user of Jenkins on openshift | ||
I want to deploy JavaEE application on OpenShift | ||
|
||
|
||
Background: | ||
Given Project [TEST_NAMESPACE] is used | ||
|
||
Scenario: Deploy JavaEE application on OpenShift | ||
Given The jenkins pod is up and runnning | ||
When The user create objects from the sample maven template by processing the template and piping the output to oc create | ||
And verify imagestream.image.openshift.io/openshift-jee-sample & imagestream.image.openshift.io/wildfly exist | ||
And verify buildconfig.build.openshift.io/openshift-jee-sample & buildconfig.build.openshift.io/openshift-jee-sample-docker exist | ||
And verify deploymentconfig.apps.openshift.io/openshift-jee-sample is created | ||
And verify service/openshift-jee-sample is created | ||
And verify route.route.openshift.io/openshift-jee-sample is created | ||
Then Trigger the build using oc start-build openshift-jee-sample | ||
Then verify the build status of openshift-jee-sample-docker build is Complete | ||
And verify the build status of openshift-jee-sample-1 is Complete | ||
And verify the JaveEE application is accessible via route openshift-jee-sample |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
Feature: Testing jenkins agent nodejs image | ||
|
||
As a user of Jenkins on openshift | ||
I want to deploy Nodejs application on OpenShift | ||
|
||
|
||
Background: | ||
Given Project [TEST_NAMESPACE] is used | ||
|
||
Scenario: Deploy sample application on openshift | ||
Given The jenkins pod is up and runnning | ||
When The user enters new-app command with nodejs_template | ||
Then Trigger the build using oc start-build | ||
Then nodejs-postgresql-example pod must come up | ||
And route nodejs-postgresql-example must be created and be accessible |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So best as I can tell, this test assumes the persistent volumes are created prior to the invocation of the test.
If that is correct @jitendar-singh I believe that should be explicitly called out here and in the other persistent*.feature files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or, ideally, you replicate the NFS based PV setup we do in the current extended tests at https://github.com/openshift/origin/blob/master/test/extended/builds/pipeline_jenkins_e2e.go#L60-L72
Then we could be on a path of removing those persistent template tests in openshift/origin and replace them with CI invocations of your new smoke tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gabemontero I will work this next.