New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1974338: Update README.md with USE_JAVA_VERSION env var explanation #1307
Conversation
README.md
Outdated
@@ -171,6 +171,7 @@ initialization by passing `-e VAR=VALUE` to the Docker run command. | |||
| `MAVEN_SLAVE_IMAGE` | Setting this value overrides the image used for the default maven agent pod configuration. For 3.x, the default maven agent pod uses `docker.io/openshift/jenkins-agent-maven-35-centos7` or `registry.redhat.io/openshift3/jenkins-agent-maven-35-rhel7` depending whether you are running the centos or rhel version of the Jenkins image. For 4.x, the image is included in the 4.0 payload via an imagestream in the openshift namespace, and the image spec points to the internal image registry. If you are running this image outside of OpenShift, you must either set this environment variable or manually update the setting to an accessible image spec. This variable must be set before Jenkins starts the first time for it to have an effect. | | |||
| `JENKINS_UC_INSECURE` | When your Jenkins Update Center repository is using a self-signed certificate with an unknown Certificate Authority, this variable allows one to bypass the repository's SSL certificate check. The variable applies to download of the plugin which may occur during Jenkins image build, if you build an extension of the jenkins image or if you run the Jenkins image and leverage one of the options to download additional plugins (use of s2i whith plugins.txt or use of `INSTALL_PLUGINS` environment variable. | | |||
| `MAVEN_MIRROR_URL` | Allows you to specify a [Maven mirror repository](https://maven.apache.org/guides/mini/guide-mirror-settings.html) in the form of `MAVEN_MIRROR_URL=https://nexus.mycompany.com/repository/maven-public`. The mirror repository is used by maven as an additional location for artifacts downloads. For more details on [how maven mirrors works](https://maven.apache.org/guides/mini/guide-mirror-settings.html), you can refer to maven documentation. | |||
| `USE_JAVA_VERSION` | Allows you to set the Java version used by the JNLP Client for the agent images. By default the value is set to `java-11` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the allowed values? What value should a developer provide to use Java 8?
/retitle Bug: 1974338: Update README.md with USE_JAVA_VERSION env var explanation |
/retitle Bug 1974338: Update README.md with USE_JAVA_VERSION env var explanation |
@waveywaves: This pull request references Bugzilla bug 1974338, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
`USE_JAVA_VERSION` env var allows the user to set the java version of the jnlp client running in the jenkins agent image.
/lgtm @rolfedh - we'll want to update the product docs for this as well. Can we drive that off of this BZ, where @waveywaves perhaps crafts an openshift/openshift-docs PR for you? Or do you prefer some other form or bookkeeping / execution? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gabemontero, waveywaves The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Also @rolfedh of course if you have opinions on the specific wording from @waveywaves let us know. |
@waveywaves: All pull requests linked via external trackers have merged: Bugzilla bug 1974338 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @gabemontero. I've created https://issues.redhat.com/browse/RHDEVDOCS-3177 to track the doc work for this Jenkins task. @Preeticp, @sounix000, Here's another Jenkins-related doc task we need to consider for our planning |
USE_JAVA_VERSION
env var allows the user to set the java version of the jnlp client running in the jenkins agent image.