Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2003204: Fix jbcrypt_path lookup #1334

Closed
wants to merge 2 commits into from
Closed

Bug 2003204: Fix jbcrypt_path lookup #1334

wants to merge 2 commits into from

Conversation

akram
Copy link
Contributor

@akram akram commented Nov 8, 2021 •
edited

In resulting image, jbcrypt is not extracted into /tmp/war but rather it is present under directories in /var/lib/jenkins/war/

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 8, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akram

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2021
@akram akram force-pushed the fix-obfuscate-password-script branch 3 times, most recently from 390a261 to 100d3ed Compare November 8, 2021 13:02
@akram akram force-pushed the fix-obfuscate-password-script branch from 100d3ed to f833306 Compare November 17, 2021 05:34
@akram
Copy link
Contributor Author

akram commented Nov 17, 2021

/retest

@akram akram changed the title WIP: Fix jbcrypt_path lookup Bug 2003204: Fix jbcrypt_path lookup Nov 17, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 17, 2021

@akram: This pull request references Bugzilla bug 2003204, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jitendar-singh

In response to this:

Bug 2003204: Fix jbcrypt_path lookup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 17, 2021
adambkaplan
adambkaplan reviewed Nov 17, 2021
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akram do we have a test case where we deploy the Jenkins template with the oauth plugin disabled? We need to ensure that we don't regress if there are upstream Jenkins changes in the future.

@akram
Copy link
Contributor Author

akram commented Nov 18, 2021

@adambkaplan I didn't see a such a test, I will prepare one.

@akram
Copy link
Contributor Author

akram commented Nov 18, 2021

closing in favor of #1345

@akram akram closed this Nov 18, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2021

@akram: This pull request references Bugzilla bug 2003204. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

Bug 2003204: Fix jbcrypt_path lookup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan adambkaplan left review comments

@jkhelil jkhelil Awaiting requested review from jkhelil

@sbose78 sbose78 Awaiting requested review from sbose78

@jitendar-singh jitendar-singh Awaiting requested review from jitendar-singh

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@akram @adambkaplan