-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JKNS-289: complete switch from ocp payload to cpaas images for both jenkins and base agent ocp images #1434
JKNS-289: complete switch from ocp payload to cpaas images for both jenkins and base agent ocp images #1434
Conversation
… base agent ocp images
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: coreydaley, gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label px-approved This does not change our product experience - we are already shipping two imagestreams for each image. |
/label docs-approved This does not have any impact to product documentation that isn't already covered elswhere (we are already shipping two imagestreams). |
/cc @jitendar-singh @prietyc123 For QE approval |
we can defer approval from qe to openshift/cluster-samples-operator#416 as that merging is when these change are actually consumable in the product /label qe-approved |
multitude of unrelated meltdowns from aws vpc to api server meltdowns (cannot even recognize the buildconfig kind) /retest |
also the changes here have no efffect on these e2e's .... the samples operator in the e2e runs does not use the imagestreams from this repo |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/hold need to update the client plugin repo to properly groupify api ref's
|
/retest |
/hold cancel |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest-required Please review the full test history for this PR and help us cut down flakes. |
my dumb self by default removed the branch .... temporarily restored it until this passes / merges |
@gabemontero: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
after this merges, and openshift/library's cron job picks it up, the we'll do the official library sync for jenkins in openshift/cluster-samples-operator#416 and be done with OCP for this
/assign @coreydaley
/assign @akram
/assign @jkhelil