Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JKNS-289: complete switch from ocp payload to cpaas images for both jenkins and base agent ocp images #1434

Conversation

gabemontero
Copy link
Contributor

after this merges, and openshift/library's cron job picks it up, the we'll do the official library sync for jenkins in openshift/cluster-samples-operator#416 and be done with OCP for this

/assign @coreydaley
/assign @akram
/assign @jkhelil

@openshift-ci openshift-ci bot requested review from otaviof and sbose78 April 21, 2022 17:39
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2022
@coreydaley
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coreydaley, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adambkaplan
Copy link
Contributor

/label px-approved

This does not change our product experience - we are already shipping two imagestreams for each image.

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Apr 21, 2022
@adambkaplan
Copy link
Contributor

/label docs-approved

This does not have any impact to product documentation that isn't already covered elswhere (we are already shipping two imagestreams).

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Apr 21, 2022
@adambkaplan
Copy link
Contributor

/cc @jitendar-singh @prietyc123

For QE approval

@gabemontero
Copy link
Contributor Author

we can defer approval from qe to openshift/cluster-samples-operator#416 as that merging is when these change are actually consumable in the product

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 21, 2022
@gabemontero
Copy link
Contributor Author

multitude of unrelated meltdowns from aws vpc to api server meltdowns (cannot even recognize the buildconfig kind)

/retest

@gabemontero
Copy link
Contributor Author

also the changes here have no efffect on these e2e's .... the samples operator in the e2e runs does not use the imagestreams from this repo

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@gabemontero
Copy link
Contributor Author

/hold

need to update the client plugin repo to properly groupify api ref's

ERROR: create returned an error;
        {err=unable to recognize no matches for kind "BuildConfig" in version "v1"

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2022
@gabemontero
Copy link
Contributor Author

/retest

@gabemontero
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@gabemontero
Copy link
Contributor Author

@gabemontero: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name Commit Details Required Rerun command
ci/prow/e2e-aws-jenkins-client-plugin 6e145d6 link true /test e2e-aws-jenkins-client-plugin

Full PR test history. Your PR dashboard.

my dumb self by default removed the branch .... temporarily restored it until this passes / merges
then will re-delete and switch test back to master branch

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 23, 2022

@gabemontero: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 79826ba into openshift:master Apr 23, 2022
@gabemontero gabemontero deleted the final-ocp-image-swap-to-cpaas branch April 23, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants