Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding build support for archs other than amd64 #19

Closed
wants to merge 1 commit into from

Conversation

Pensu
Copy link

@Pensu Pensu commented Jul 19, 2019

This PR removes hardcoded amd64 and replaces it with env GOARCH, which enables the build to create binaries for the platform it is running on.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 19, 2019
@openshift-ci-robot
Copy link

Hi @Pensu. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 19, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Pensu
To complete the pull request process, please assign squat
You can assign the PR to them by writing /assign @squat in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@paulfantom
Copy link

@Pensu please look at #15 as this is the same PR. There is also an explanation on why we don't want to merge it and a possible workaround.

/close

@openshift-ci-robot
Copy link

@paulfantom: Closed this PR.

In response to this:

@Pensu please look at #15 as this is the same PR. There is also an explanation on why we don't want to merge it and a possible workaround.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Pensu
Copy link
Author

Pensu commented Jul 19, 2019

@Pensu please look at #15 as this is the same PR. There is also an explanation on why we don't want to merge it and a possible workaround.

/close

Oh, didn't see that. Apologies for the noise. Will comment there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants