Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1883378: Openapi spec is missing for prometheus-adapter aggregated api-resources #52

Closed

Conversation

arajkumar
Copy link

@arajkumar arajkumar commented Jul 15, 2021

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 15, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot requested review from bison and prashbnair July 15, 2021 12:46
@openshift-ci
Copy link

openshift-ci bot commented Jul 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arajkumar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2021
@arajkumar
Copy link
Author

/test all

@arajkumar
Copy link
Author

This has been tackled in upstream kubernetes-sigs#435, once approved it will be back ported to openshift downstream.

@arajkumar arajkumar changed the title WIP: Missing extension in spec WIP: Bug 1883378: Openapi spec is missing for prometheus-adapter aggregated api-resources Jul 15, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 15, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 15, 2021

@arajkumar: This pull request references Bugzilla bug 1883378, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @juzhao

In response to this:

WIP: Bug 1883378: Openapi spec is missing for prometheus-adapter aggregated api-resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@arajkumar
Copy link
Author

/hold

@openshift-ci openshift-ci bot requested a review from juzhao July 15, 2021 14:29
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2021
Signed-off-by: Arunprasad Rajkumar <arajkuma@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Jul 20, 2021

@arajkumar: This pull request references Bugzilla bug 1883378, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @juzhao

In response to this:

WIP: Bug 1883378: Openapi spec is missing for prometheus-adapter aggregated api-resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@arajkumar arajkumar changed the title WIP: Bug 1883378: Openapi spec is missing for prometheus-adapter aggregated api-resources Bug 1883378: Openapi spec is missing for prometheus-adapter aggregated api-resources Jul 20, 2021
@arajkumar arajkumar marked this pull request as ready for review July 20, 2021 11:47
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2021
@arajkumar
Copy link
Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2021
@arajkumar
Copy link
Author

/assign @dgrisonnet

@arajkumar
Copy link
Author

I will be part of next prometheus-adapter release.

@arajkumar arajkumar closed this Jul 23, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 23, 2021

@arajkumar: This pull request references Bugzilla bug 1883378. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

Bug 1883378: Openapi spec is missing for prometheus-adapter aggregated api-resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants