Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-21621: Add a toggle to disable HTTP/2 on the server to mitigate CVE-2023-44487 #88

Merged
merged 1 commit into from Nov 6, 2023

Conversation

machine424
Copy link

@machine424 machine424 commented Nov 3, 2023

until the Go standard library and golang.org/x/net are fully fixed.


The patch was merged upstream by not yet released kubernetes-sigs#618

/cc @simonpasquier


I'll set the flag in CMO once this is merged

until the Go standard library and golang.org/x/net are fully fixed.
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2023
@simonpasquier
Copy link

/lgtm
/hold
Just to be sure, we'll need another change into CMO to disable HTTP2 for prometheus-adapter?

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2023
@machine424
Copy link
Author

machine424 commented Nov 3, 2023

Just to be sure, we'll need another change into CMO to disable HTTP2 for prometheus-adapter?

Yep, I'll set the flag in CMO once this is merged

(I edited the description couple of minutes after creation)

@machine424
Copy link
Author

/retitle OCPBUGS-21621: Add a toggle to disable HTTP/2 on the server to mitigate CVE-2023-44487

@openshift-ci openshift-ci bot changed the title Add a toggle to disable HTTP/2 on the server to mitigate CVE-2023-44487 OCPBUGS-21621: Add a toggle to disable HTTP/2 on the server to mitigate CVE-2023-44487 Nov 3, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Nov 3, 2023
@openshift-ci-robot
Copy link

@machine424: This pull request references Jira Issue OCPBUGS-21621, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

until the Go standard library and golang.org/x/net are fully fixed.


The patch was merged upstream by not yet released kubernetes-sigs#618

/cc @simonpasquier


I'll set the flag in CMO once this is merged

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from juzhao November 3, 2023 10:28
Copy link

openshift-ci bot commented Nov 3, 2023

@machine424: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@simonpasquier
Copy link

/lgtm
@machine424 can you open the CMO PR and link to the OCPBUGS? This way, the bug won't move to the MODIFIED state directly.

Copy link

openshift-ci bot commented Nov 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: machine424, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [machine424,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@machine424
Copy link
Author

Done openshift/cluster-monitoring-operator#2145
(I wanted to create another OCPBUGS for that to make use of /cherrypick automation, but no problem)

@simonpasquier
Copy link

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2023
@openshift-ci openshift-ci bot merged commit 07b7bf7 into openshift:master Nov 6, 2023
6 checks passed
@openshift-ci-robot
Copy link

@machine424: Jira Issue OCPBUGS-21621: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-21621 has not been moved to the MODIFIED state.

In response to this:

until the Go standard library and golang.org/x/net are fully fixed.


The patch was merged upstream by not yet released kubernetes-sigs#618

/cc @simonpasquier


I'll set the flag in CMO once this is merged

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link

Fix included in accepted release 4.15.0-0.nightly-2023-11-06-182702

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-prometheus-adapter-container-v4.15.0-202311202349.p0.g07b7bf7.assembly.stream for distgit ose-prometheus-adapter.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants