Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

Verify if using a thread pool fix the EOF error #498

Closed

Conversation

nak3
Copy link

@nak3 nak3 commented Jul 13, 2020

I suspect that the EOF is due to hitting a rate limit on server side.

But it happens only sendRequests in util.go. So let's try to use same codes (thread pool) like other concurrent requests and see if it fixes the issue or not.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nak3
To complete the pull request process, please assign markusthoemmes
You can assign the PR to them by writing /assign @markusthoemmes in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the area/test-and-release Issues or PRs related to test and release label Jul 13, 2020
@markusthoemmes
Copy link

@nak3 this indeed seems to have helped but it has me wonder: Which of our components would be overloaded here? Upstream doesn't seem to have issues 🤔

@alanfx alanfx force-pushed the release-next branch 2 times, most recently from 44c2c3a to 8128e78 Compare July 16, 2020 00:02
@openshift-ci-robot
Copy link

@nak3: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 16, 2020
@alanfx alanfx force-pushed the release-next branch 5 times, most recently from 0efe4c0 to db3d741 Compare July 21, 2020 00:02
@openshift-ci-robot
Copy link

@nak3: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/4.3-e2e-aws-ocp-43 e21fa2d link /test 4.3-e2e-aws-ocp-43
ci/prow/4.5-images e21fa2d link /test 4.5-images
ci/prow/4.5-e2e-aws-ocp-45 e21fa2d link /test 4.5-e2e-aws-ocp-45
ci/prow/4.6-images e21fa2d link /test 4.6-images
ci/prow/4.6-e2e-aws-ocp-46 e21fa2d link /test 4.6-e2e-aws-ocp-46

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nak3
Copy link
Author

nak3 commented Jul 21, 2020

@nak3 this indeed seems to have helped but it has me wonder: Which of our components would be overloaded here? Upstream doesn't seem to have issues thinking

Yes, that is good point and I cannot explain it. I will come back after some more investigation.

@nak3 nak3 closed this Jul 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/test-and-release Issues or PRs related to test and release needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
4 participants