Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump kube-rbac-proxy #49

Merged
merged 4 commits into from Jun 29, 2021
Merged

Conversation

s-urbaniak
Copy link

/cc @stlaz

@openshift-ci openshift-ci bot requested a review from stlaz June 28, 2021 14:18
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2021
@s-urbaniak
Copy link
Author

/test e2e-aws

@slaskawi
Copy link

The code itself looks good to me.

But I'd appreciate a few minor updates:

  • Please squash your changes into two commits - one for updating the OWNERS and the other for updating the code.
  • Please add some reference to Bugzilla or JIRA so that we know what is the context of this change.

@s-urbaniak
Copy link
Author

@slaskawi this is a mechanical upstream bump, we don't squash upstream commits, the OWNERS change is a separate commit.

@slaskawi
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: s-urbaniak, slaskawi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4ca9825 into openshift:master Jun 29, 2021
@s-urbaniak s-urbaniak deleted the bump branch June 29, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants