Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-4.14: disable http2 #78

Closed

Conversation

ibihim
Copy link

@ibihim ibihim commented Oct 19, 2023

What

  • Disable HTTP/2 by default.
  • Set it up, such that we could add a flag easily.

Why

  • CVE-2023-44487.
  • Hesitant to add a new flag to manage, hopefully it gets fixed by Go.

@openshift-ci
Copy link

openshift-ci bot commented Oct 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ibihim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2023
@ibihim ibihim changed the title http2: disable http2 release-4.14: disable http2 Oct 19, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 19, 2023

@ibihim: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ibihim
Copy link
Author

ibihim commented Oct 20, 2023

#78

@ibihim ibihim closed this Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant