Bug 1755757: store: add kube_node_role metric #17
Conversation
|
@brancz: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
size/M
|
@brancz we need BZ for it |
brancz
force-pushed
the
4.1-node-role
branch
from
1897e62
to
c90b65c
Compare
|
I verified this works on a cluster bot cluster. |
|
@brancz I duplicated the original bugzilla and target it to the 4.1 release, can you refernce that bugzilla please, I can't seem to edit the title 🤷♀ https://bugzilla.redhat.com/show_bug.cgi?id=1750283 |
brancz
changed the title
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
@brancz: This pull request references Bugzilla bug 1750283, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@brancz @lilic the 4.2 BZ (https://bugzilla.redhat.com/show_bug.cgi?id=1749451) is still in assigned, we'll need to see that get fixed/verified before this PR can merge into a z-stream |
|
/bugzilla refresh |
|
@lilic: This pull request references Bugzilla bug 1750283, which is valid. The bug has been moved to the POST state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/valid-bug
|
@bparees thanks, this is now ready to be merged. |
|
Seems like the wrong bugzilla is linked, should be https://bugzilla.redhat.com/show_bug.cgi?id=1755757 |
brancz
changed the title
|
@brancz: This pull request references Bugzilla bug 1755757, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brancz, s-urbaniak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
There's other work involved to resolve the bug in question that won't be queued before the merge window closes, therefore we'll defer this until the next 4.1.z merge window. |
|
@sdodson I believe we said we can merge today? I changed the bugzilla to medium priority as per the prior discussion. |
|
@mrunalp starts his term as patch manager today. I'll sync up with him when he's online. |
| kube_node_info{container_runtime_version="rkt",kernel_version="kernel",kubelet_version="kubelet",kubeproxy_version="kubeproxy",node="127.0.0.1",os_image="osimage",provider_id="provider://i-randomidentifier"} 1 | ||
| kube_node_labels{label_type="master",node="127.0.0.1"} 1 | ||
| kube_node_labels{label_node_role_kubernetes_io_master="",node="127.0.0.1"} 1 | ||
| kube_node_role{node="127.0.0.1",role="master"} 1 |
There was a problem hiding this comment.
nit: Are we missing a gofmt run here?
There was a problem hiding this comment.
This is to sync with the upstream repo, if we were to make the change here we would diverge with the upstream branch.
mrunalp
added
the
cherry-pick-approved
Backport of #16 for 4.1.
@lilic @paulfantom @lilic