Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1800430: Sync with 1.9 release branch #26

Merged
merged 13 commits into from Mar 2, 2020
Merged

Bug 1800430: Sync with 1.9 release branch #26

merged 13 commits into from Mar 2, 2020

Conversation

lilic
Copy link

@lilic lilic commented Feb 21, 2020

cc @openshift/openshift-team-monitoring

tariq1890 and others added 13 commits February 2, 2020 23:01
@tariq1890
fix: use the correct expectedType for networkPolicy reflector
f52762a
@k8s-ci-robot
Merge pull request kubernetes#1042 from tariq1890/fix_nptype
5145c90 
fix: use the correct expectedType for networkPolicy reflector
@mjura
internal/store/builder.go: Fix K8s API version
19bad44 
(cherry picked from commit 7e6ee51)
@k8s-ci-robot
Merge pull request kubernetes#1043 from mjura/v1.9-fix-k8s-api
85a2520 
internal/store/builder.go: Fix K8s API version
@brancz
*: Cut v1.9.4
983713c
@k8s-ci-robot
Merge pull request kubernetes#1044 from brancz/cut-1.9.4
440c92f 
*: Cut v1.9.4
@lilic
internal/store/validatingwebhookconfiguration.go: Switch to v1
9767846 
As we are expecting v1 we should also create a watch on v1. Otherwise
see the following error in the logs:

"expected type *v1.ValidatingWebhookConfiguration, but watch
event object had type *v1beta1.ValidatingWebhookConfiguration"
@lilic
tests/e2e.sh: Switch to test with kubernetes version 1.17.3
7c28c43
@k8s-ci-robot
Merge pull request kubernetes#1052 from lilic/v1beta1-vwh
5faeb5f 
internal/store/validatingwebhookconfiguration.go: Switch to v1
@lilic
README.md,VERSION,examples: Cut 1.9.5 release
e4c573e
@k8s-ci-robot
Merge pull request kubernetes#1067 from lilic/cut-1.9.5
7710f43 
Cut v1.9.5 release
@lilic
Merge remote-tracking branch 'upstream/release-1.9' into sync-1.9.5
91dcb56
@openshift-merge-robot
Merge pull request #25 from lilic/sync-1.9.5
df86556 
*: Bring in v1.9.5
@openshift-ci-robot
Copy link

@lilic: This pull request references Bugzilla bug 1800430, which is invalid:

  • expected Bugzilla bug 1800430 to depend on a bug in one of the following states: MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1800430: Sync with 1.9 release branch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 21, 2020
@lilic lilic requested a review from a team February 21, 2020 09:04
@s-urbaniak
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilic, s-urbaniak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lilic
Copy link
Author

lilic commented Feb 21, 2020

/retest

CI 🤷‍♀ :(

@lilic
Copy link
Author

lilic commented Feb 21, 2020

/retest

1 similar comment
@lilic
Copy link
Author

lilic commented Feb 21, 2020

/retest

@lilic
Copy link
Author

lilic commented Feb 21, 2020

/hold

not sure this fixes it 🤔

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2020
@lilic
Copy link
Author

lilic commented Feb 21, 2020

/hold cancel

it does fix it for the validatingwebhook but errors are seen for other resources, will fix in another PR in upstream first.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2020
@s-urbaniak s-urbaniak added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 21, 2020
@lilic
Copy link
Author

lilic commented Feb 24, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link

@lilic: This pull request references Bugzilla bug 1800430, which is invalid:

  • expected Bugzilla bug 1800430 to depend on a bug in one of the following states: MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lilic
Copy link
Author

lilic commented Feb 24, 2020

/bugzilla refresh

huh

@openshift-ci-robot
Copy link

@lilic: This pull request references Bugzilla bug 1800430, which is invalid:

  • expected Bugzilla bug 1800430 to depend on a bug in one of the following states: MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

huh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@s-urbaniak
Copy link

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 24, 2020
@openshift-ci-robot
Copy link

@s-urbaniak: This pull request references Bugzilla bug 1800430, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@s-urbaniak
Copy link

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Feb 24, 2020
@openshift-ci-robot
Copy link

@s-urbaniak: This pull request references Bugzilla bug 1800430, which is invalid:

  • expected dependent Bugzilla bug 1806478 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@s-urbaniak s-urbaniak added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 24, 2020
@lilic
Copy link
Author

lilic commented Mar 2, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 2, 2020
@openshift-ci-robot
Copy link

@lilic: This pull request references Bugzilla bug 1800430, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.0) matches configured target release for branch (4.4.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1806478 is in the state VERIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1806478 targets the "4.5.0" release, matching the expected (4.5.0) release
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 2, 2020
@lilic
Copy link
Author

lilic commented Mar 2, 2020

tide Pending — Not mergeable. Needs bugzilla/valid-bug label.

clearly there is a label :D

@lilic
Copy link
Author

lilic commented Mar 2, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link

@lilic: This pull request references Bugzilla bug 1800430, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.4.0) matches configured target release for branch (4.4.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1806478 is in the state VERIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1806478 targets the "4.5.0" release, matching the expected (4.5.0) release
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lilic
Copy link
Author

lilic commented Mar 2, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@lilic
Copy link
Author

lilic commented Mar 2, 2020

/retest

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b659f76 into release-4.4 Mar 2, 2020
@openshift-ci-robot
Copy link

@lilic: All pull requests linked via external trackers have merged. Bugzilla bug 1800430 has been moved to the MODIFIED state.

In response to this:

Bug 1800430: Sync with 1.9 release branch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulfantom paulfantom Awaiting requested review from paulfantom

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

Assignees

@s-urbaniak s-urbaniak

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@lilic @openshift-ci-robot @s-urbaniak @openshift-bot @openshift-merge-robot @tariq1890 @k8s-ci-robot @mjura @brancz