NO-ISSUE: UPSTREAM: 118886: KEP-1040: Deep disablement for APF based on --enable-priority-and-fairness. #55
Conversation
|
@p0lyn0mial: No Jira issue with key KEP-1040 exists in the tracker at https://issues.redhat.com/. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold I'd like to verify it first. |
openshift-ci
bot
added
the
do-not-merge/hold
|
@p0lyn0mial: No Jira issue with key KEP-1040 exists in the tracker at https://issues.redhat.com/. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
…e-priority-and-fairness.
p0lyn0mial
force-pushed
the
openshift/openshift-apiserver-4.15-kubernetes-1.28.3-disablement-apf
branch
from
4a6b86a
to
b4c0eac
Compare
|
@p0lyn0mial: No Jira issue with key KEP-1040 exists in the tracker at https://issues.redhat.com/. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@p0lyn0mial: No Jira issue with key KEP-1040 exists in the tracker at https://issues.redhat.com/. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
yes, APF should be disabled in an aggregated apiserver /lgtm |
|
@p0lyn0mial: No Jira issue with key KEP-1040 exists in the tracker at https://issues.redhat.com/. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/assign @benluddy |
p0lyn0mial
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@p0lyn0mial: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@p0lyn0mial: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
/assign @deads2k for approval |
|
/approve |
mfojtik
merged commit be9e4a6
into
openshift:openshift-apiserver-4.15-kubernetes-1.28.3
pulls kubernetes/kubernetes#118886
which will allow for disabling the apf by passing a command line flag.
the proof PR for oauth-apiserver openshift/oauth-apiserver#106
the proof PR for openshift-apiserver openshift/openshift-apiserver#418