Bug 1823667: UPSTREAM: <carry>: Get replicas always from API server #147

enxebre · 2020-05-04T10:17:11Z

When getting Replicas() the local struct in the scalable resource might be stale. To mitigate possible side effects, we want always get a fresh replicas.

This is one in a series of PR to mitigate kubernetes#3104
Once we got all of them merged we'll put a PR upstream.

enxebre · 2020-05-04T10:17:38Z

/hold
to include a unit test

openshift-ci-robot · 2020-05-04T10:29:00Z

@enxebre: An error was encountered searching for bug 1823667 on the Bugzilla server at https://bugzilla.redhat.com:

Get https://bugzilla.redhat.com/rest/bug/1823667?api_key=CENSORED: dial tcp: i/o timeout
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1823667: UPSTREAM: : Get replicas always from API server

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

enxebre · 2020-05-04T10:31:29Z

/bugzilla refresh

openshift-ci-robot · 2020-05-04T10:31:33Z

@enxebre: An error was encountered adding this pull request to the external tracker bugs for bug 1823667 on the Bugzilla server at https://bugzilla.redhat.com:

JSONRPC error 32000: There was an error reported for a GitHub REST call. URL: https://api.github.com/repos/openshift/kubernetes-autoscaler/pulls/147 Error: 403 Forbidden at /loader/0x55fec87b60d0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 107. at /loader/0x55fec87b60d0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 107. eval {...} called at /loader/0x55fec87b60d0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 94 Bugzilla::Extension::ExternalBugs::Type::GitHub::_do_rest_call('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x55fed4...', 'https://api.github.com/repos/openshift/kubernetes-autoscaler/...', 'GET') called at /loader/0x55fec87b60d0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 58 Bugzilla::Extension::ExternalBugs::Type::GitHub::get_data('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x55fed4...', 'Bugzilla::Extension::ExternalBugs::Bug=HASH(0x55fed3d70a08)') called at /loader/0x55fec87b60d0/Bugzilla/Extension/ExternalBugs/Bug.pm line 298 eval {...} called at /loader/0x55fec87b60d0/Bugzilla/Extension/ExternalBugs/Bug.pm line 298 Bugzilla::Extension::ExternalBugs::Bug::update_ext_info('Bugzilla::Extension::ExternalBugs::Bug=HASH(0x55fed3d70a08)', 1) called at /loader/0x55fec87b60d0/Bugzilla/Extension/ExternalBugs/Bug.pm line 121 Bugzilla::Extension::ExternalBugs::Bug::create('Bugzilla::Extension::ExternalBugs::Bug', 'HASH(0x55fed42189a8)') called at /var/www/html/bugzilla/extensions/ExternalBugs/Extension.pm line 873 Bugzilla::Extension::ExternalBugs::bug_start_of_update('Bugzilla::Extension::ExternalBugs=HASH(0x55fed34368c8)', 'HASH(0x55fed33cd070)') called at /var/www/html/bugzilla/Bugzilla/Hook.pm line 21 Bugzilla::Hook::process('bug_start_of_update', 'HASH(0x55fed33cd070)') called at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1170 Bugzilla::Bug::update('Bugzilla::Bug=HASH(0x55fed31542d8)') called at /loader/0x55fec87b60d0/Bugzilla/Extension/ExternalBugs/WebService.pm line 84 Bugzilla::Extension::ExternalBugs::WebService::add_external_bug('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x55fed334e9a8)') called at (eval 2404) line 1 eval ' $procedure->{code}->($self, @params) ;' called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 220 JSON::RPC::Legacy::Server::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x55fed377a558)') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 295 Bugzilla::WebService::Server::JSONRPC::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x55fed377a558)') called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 126 JSON::RPC::Legacy::Server::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 70 Bugzilla::WebService::Server::JSONRPC::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/jsonrpc.cgi line 31 ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::var_www_html_bugzilla_jsonrpc_2ecgi::handler('Apache2::RequestRec=SCALAR(0x55fed341a590)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 eval {...} called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 ModPerl::RegistryCooker::run('Bugzilla::ModPerl::ResponseHandler=HASH(0x55fed2e77608)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 173 ModPerl::RegistryCooker::default_handler('Bugzilla::ModPerl::ResponseHandler=HASH(0x55fed2e77608)') called at /usr/lib64/perl5/vendor_perl/ModPerl/Registry.pm line 32 ModPerl::Registry::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x55fed341a590)') called at /var/www/html/bugzilla/mod_perl.pl line 139 Bugzilla::ModPerl::ResponseHandler::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x55fed341a590)') called at (eval 2404) line 0 eval {...} called at (eval 2404) line 0
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

JoelSpeed

One nit, otherwise looks good

JoelSpeed · 2020-05-04T13:50:02Z

cluster-autoscaler/cloudprovider/clusterapi/clusterapi_nodegroup.go

+	size, err := ng.scalableResource.Replicas()
+	intSize := int(size)
+	if err != nil {
+		return err
 	}


nit: Don't need to declare intSize until the error is checked

Suggested change

size, err := ng.scalableResource.Replicas()

intSize := int(size)

if err != nil {

return err

}

size, err := ng.scalableResource.Replicas()

if err != nil {

return err

}

intSize := int(size)

elmiko

this looks like a good improvement to me
/approve

When getting Replicas() the local struct in the scalable resource might be stale. To mitigate possible side effects, we want always get a fresh replicas. This is one in a series of PR to mitigate kubernetes#3104 Once we got all merge we'll put a PR upstream.

enxebre · 2020-05-05T09:25:42Z

added unit tests
/hold cancel
/bugzilla refresh

openshift-ci-robot · 2020-05-05T09:25:46Z

@enxebre: This pull request references Bugzilla bug 1823667, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

added unit tests
/hold cancel
/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alexander-demicev

/approve

openshift-ci-robot · 2020-05-05T09:28:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demichev, elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~cluster-autoscaler/cloudprovider/clusterapi/OWNERS~~ [alexander-demichev,elmiko]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

JoelSpeed

/lgtm

openshift-ci-robot · 2020-05-05T10:46:44Z

@enxebre: Some pull requests linked via external trackers have merged: openshift/kubernetes-autoscaler#147. The following pull requests linked via external trackers have not merged:

openshift/kubernetes-autoscaler#148 is open
Bugzilla bug 1823667 has been moved to the MODIFIED state.

In response to this:

Bug 1823667: UPSTREAM: : Get replicas always from API server

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from alexander-demicev and JoelSpeed May 4, 2020 10:17

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2020

enxebre force-pushed the replicas branch from fcac471 to 5f4f4c1 Compare May 4, 2020 10:22

enxebre changed the title ~~UPSTREAM: carry: Get replicas always from API server~~ UPSTREAM: <carry>: Get replicas always from API server May 4, 2020

enxebre changed the title ~~UPSTREAM: <carry>: Get replicas always from API server~~ Bug 1823667: UPSTREAM: <carry>: Get replicas always from API server May 4, 2020

JoelSpeed reviewed May 4, 2020

View reviewed changes

elmiko approved these changes May 4, 2020

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2020

enxebre force-pushed the replicas branch from 5f4f4c1 to 6f34947 Compare May 5, 2020 09:22

alexander-demicev approved these changes May 5, 2020

View reviewed changes

JoelSpeed reviewed May 5, 2020

View reviewed changes

openshift-ci-robot assigned JoelSpeed May 5, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2020

openshift-merge-robot merged commit 9d397d2 into openshift:master May 5, 2020

openshift-ci-robot mentioned this pull request May 5, 2020

Bug 1823667: UPSTREAM: <carry>: Compare against minSize in deleteNodes() #150

Merged

JoelSpeed mentioned this pull request May 7, 2020

Bug 1835851: Update DeleteNodesTwice test #151

Merged

openshift-ci-robot mentioned this pull request May 21, 2020

Bug 1823667: UPSTREAM: <carry>: Add mutex to DeleteNodes #149

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1823667: UPSTREAM: <carry>: Get replicas always from API server #147

Bug 1823667: UPSTREAM: <carry>: Get replicas always from API server #147

enxebre commented May 4, 2020 •

edited

enxebre commented May 4, 2020

openshift-ci-robot commented May 4, 2020

enxebre commented May 4, 2020

openshift-ci-robot commented May 4, 2020

JoelSpeed left a comment

JoelSpeed May 4, 2020

elmiko left a comment

enxebre commented May 5, 2020

openshift-ci-robot commented May 5, 2020

alexander-demicev left a comment

openshift-ci-robot commented May 5, 2020

JoelSpeed left a comment

openshift-ci-robot commented May 5, 2020

Bug 1823667: UPSTREAM: <carry>: Get replicas always from API server #147

Bug 1823667: UPSTREAM: <carry>: Get replicas always from API server #147

Conversation

enxebre commented May 4, 2020 • edited

enxebre commented May 4, 2020

openshift-ci-robot commented May 4, 2020

enxebre commented May 4, 2020

openshift-ci-robot commented May 4, 2020

JoelSpeed left a comment

Choose a reason for hiding this comment

JoelSpeed May 4, 2020

Choose a reason for hiding this comment

elmiko left a comment

Choose a reason for hiding this comment

enxebre commented May 5, 2020

openshift-ci-robot commented May 5, 2020

alexander-demicev left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented May 5, 2020

JoelSpeed left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented May 5, 2020

enxebre commented May 4, 2020 •

edited