Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PODAUTO-91: Add joelsmith to OWNERS for approving of VPA-only PRs #273

Merged
merged 1 commit into from Dec 13, 2023

Conversation

joelsmith
Copy link

Since some VPA-only PRs touch files in the root directory, this will make the pod autoscaling team more independent

@openshift-ci openshift-ci bot requested review from nrb and racheljpg December 13, 2023 17:58
Copy link

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2023
Copy link

openshift-ci bot commented Dec 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2023
@joelsmith joelsmith changed the title Add joelsmith to OWNERS for approving of VPA-only PRs PODAUTO-91: Add joelsmith to OWNERS for approving of VPA-only PRs Dec 13, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 13, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 13, 2023

@joelsmith: This pull request references PODAUTO-91 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Since some VPA-only PRs touch files in the root directory, this will make the pod autoscaling team more independent

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

openshift-ci bot commented Dec 13, 2023

@joelsmith: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit a2b58de into openshift:master Dec 13, 2023
7 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build atomic-openshift-cluster-autoscaler-container-v4.16.0-202312140031.p0.ga2b58de.assembly.stream for distgit atomic-openshift-cluster-autoscaler.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-vertical-pod-autoscaler-container-v4.16.0-202312140031.p0.ga2b58de.assembly.stream for distgit vertical-pod-autoscaler.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants