PODAUTO-99: Fix VPA e2e test failures

[jkyros]

What this PR does / why we need it:

• The upstream VPA tests were broken when we did the rebase (It looks like maybe we don't run those here and maybe we should? )
• We run them downstream for the VPA operator, where they currently do not work, e.g. PODAUTO-99: Updates for 4.16  vertical-pod-autoscaler-operator#155
• This was fixed upstream Fix VPA e2e test failures kubernetes/autoscaler#6391 but we didn't get it when we did our rebase OCPCLOUD-2431: rebase on upstream 1.29.0 release #285 because it happened after our rebase
• This PR just brings those fixes down as a "carry until" patch so we can test the VPA operator again
• (If there is a better way I should be doing this, absolutely let me know)

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[openshift-ci-robot]

@jkyros: This pull request references PODAUTO-99 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@jkyros: This pull request references PODAUTO-99 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

What this PR does / why we need it:

• The upstream VPA tests were broken when we did the rebase (It looks like maybe we don't run those here and maybe we should? )
• We run them downstream for the VPA operator, where they currently do not work, e.g. PODAUTO-99: Updates for 4.16  vertical-pod-autoscaler-operator#155
• This was fixed upstream Fix VPA e2e test failures kubernetes/autoscaler#6391 but we didn't get it when we did our rebase OCPCLOUD-2431: rebase on upstream 1.29.0 release #285 because it happened after our rebase
• This PR just brings those fixes down as a "carry until" patch so we can test the VPA operator again
• (If there is a better way I should be doing this, absolutely let me know)

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jkyros]

/test e2e-hypershift

[joelsmith]

/lgtm
/retest

[joelsmith]

/label acknowledge-critical-fixes-only
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelsmith

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• vertical-pod-autoscaler/OWNERS [joelsmith]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD cb4f7f2 and 2 for PR HEAD 3bb1ea7 in total

[joelsmith]

/retest

[jkyros]

e2e-hypershift is failing because a capi provider container is crashing. I don't know why yet, but it's not related to this PR, it's happening in #287 also (and all that's PR is doing is updating a .snyk file):

util.go:484: Container manager in pod capi-provider-5f658fc869-8pmlk has a restartCount > 0 (1)

[jkyros]

Global history seems to think this is a flake and it does sometimes pass, I'm going to try one more time and see if I can get more favorable timings.

It looks like context deadline exceeded on the leaderelection lease, causing the pod to think it lost the election and restart:

E0220 15:51:36.261880       1 leaderelection.go:327] error retrieving resource lock e2e-clusters-6vd97-example-jvz6f/controller-leader-elect-capa: Get "https://172.29.0.1:443/apis/coordination.k8s.io/v1/namespaces/e2e-clusters-6vd97-example-jvz6f/leases/controller-leader-elect-capa": context deadline exceeded
I0220 15:51:36.261907       1 leaderelection.go:280] failed to renew lease e2e-clusters-6vd97-example-jvz6f/controller-leader-elect-capa: timed out waiting for the condition
E0220 15:51:36.261952       1 logger.go:94] "setup: problem running manager" err="leader election lost"
I0220 15:51:36.261978       1 recorder.go:104] "events: capi-provider-5f658fc869-8pmlk_cebbd79a-caa2-48b1-aeb2-bbe759f63ab5 stopped leading" type="Normal" object={"kind":"Lease","namespace":"e2e-clusters-6vd97-example-jvz6f","name":"controller-leader-elect-capa","uid":"b1d56836-3f63-4c82-8723-8ab9fce94359","apiVersion":"coordination.k8s.io/v1","resourceVersion":"19855"} reason="LeaderElection"

/retest

[joelsmith]

/retest

[openshift-ci]

@jkyros: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-vertical-pod-autoscaler-container-v4.16.0-202402210509.p0.gd832711.assembly.stream.el9 for distgit vertical-pod-autoscaler.
All builds following this will include this PR.