Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: <carry>: test/openshift/e2e: switch namespace to openshift-machine-api #33

Merged
merged 1 commit into from
Feb 12, 2019
Merged

UPSTREAM: <carry>: test/openshift/e2e: switch namespace to openshift-machine-api #33

merged 1 commit into from
Feb 12, 2019

Conversation

frobware
Copy link

@frobware frobware commented Feb 8, 2019 •
edited

As we have now pivoted to machine.openshift.io/v1beta1 this changes the namespace when running the tests to openshift-machine-api for consistency.

@frobware
Copy link
Author

frobware commented Feb 8, 2019

/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 8, 2019
@frobware frobware mentioned this pull request Feb 8, 2019
Merged
@enxebre enxebre mentioned this pull request Feb 11, 2019
Merged
@frobware
Copy link
Author

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 11, 2019
@frobware frobware mentioned this pull request Feb 11, 2019
Merged
@frobware frobware changed the title test/openshift/e2e: switch namespace to openshift-machine-api UPSTREAM: <carry>: test/openshift/e2e: switch namespace to openshift-machine-api Feb 11, 2019
@frobware
Copy link
Author

/retest

@enxebre
Copy link
Member

enxebre commented Feb 12, 2019

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2019
@enxebre enxebre mentioned this pull request Feb 12, 2019
Closed
@enxebre
Copy link
Member

enxebre commented Feb 12, 2019

needs openshift/cluster-autoscaler-operator#43

@frobware
Copy link
Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 7719e97 into openshift:master Feb 12, 2019
@frobware frobware deleted the switch-namespace branch March 22, 2019 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ingvagabund ingvagabund ingvagabund approved these changes

@spangenberg spangenberg Awaiting requested review from spangenberg

@vikaschoudhary16 vikaschoudhary16 Awaiting requested review from vikaschoudhary16

Assignees

@enxebre enxebre

Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@frobware @enxebre @ingvagabund @openshift-ci-robot @openshift-merge-robot