Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1893637: Fix bug in reflector not recovering from "Too large resource version" #161

Merged
merged 5 commits into from Nov 5, 2020
Merged

Bug 1893637: Fix bug in reflector not recovering from "Too large resource version" #161

merged 5 commits into from Nov 5, 2020

Conversation

p0lyn0mial
Copy link

No description provided.

@openshift-ci-robot
Copy link

@p0lyn0mial: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

bump kube to 1.18.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

p0lyn0mial
p0lyn0mial commented Sep 28, 2020
View reviewed changes
hack/update-codegen.sh
@@ -36,7 +36,7 @@ git clone git@github.com:kubernetes/code-generator.git
popd
pushd ${WORK_DIR}/go/src/k8s.io/code-generator
# The version needs to match the one in Gopkg.toml
git checkout kubernetes-1.15.0-alpha.0
git checkout kubernetes-1.18.6
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to manually copy the generated clientset cp -r github.com/kubernetes-sigs/kube-storage-version-migrator/pkg/clients pkg

@p0lyn0mial
Copy link
Author

/hold

how do I test it ?

/e2e-aws-operator-encryption

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 28, 2020
@p0lyn0mial
Copy link
Author

/test e2e-aws-operator

@openshift-ci-robot
Copy link

@p0lyn0mial: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test e2e-aws
  • /test images
  • /test unit
  • /test verify

Use /test all to run all jobs.

In response to this:

/test e2e-aws-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@p0lyn0mial
Copy link
Author

/test e2e-aws

1 similar comment
@p0lyn0mial
Copy link
Author

/test e2e-aws

@p0lyn0mial
Copy link
Author

/test e2e-aws-encryption

@openshift-ci-robot
Copy link

@p0lyn0mial: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test e2e-aws
  • /test images
  • /test unit
  • /test verify

Use /test all to run all jobs.

In response to this:

/test e2e-aws-encryption

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sanchezl
sanchezl reviewed Sep 29, 2020
View reviewed changes
Copy link

@sanchezl sanchezl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting a diff in pkg/apis/migration/v1alpha1/zz_generated.deepcopy.go when I run update-codegen.sh

go.mod Outdated
@@ -3,33 +3,31 @@ module github.com/kubernetes-sigs/kube-storage-version-migrator
go 1.12
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
go 1.12
go 1.13

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@sanchezl
Copy link

how do I test it ?

You'll have to make proof PRs for library-go, kas-o, oas-o.

@p0lyn0mial p0lyn0mial changed the title bump kube to 1.18.6 Bug 1880327: Fix bug in reflector not recovering from "Too large resource version" Sep 29, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 29, 2020
@openshift-ci-robot
Copy link

@p0lyn0mial: This pull request references Bugzilla bug 1880327, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1880327: Fix bug in reflector not recovering from "Too large resource version"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@p0lyn0mial
Copy link
Author

/retest

1 similar comment
@p0lyn0mial
Copy link
Author

/retest

@sttts
Copy link

sttts commented Oct 13, 2020

/assign @sanchezl

@p0lyn0mial
Copy link
Author

/test e2e-aws-operator-encryption

@p0lyn0mial
Copy link
Author

/retest

@openshift-ci-robot
Copy link

@p0lyn0mial: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test e2e-aws
  • /test e2e-aws-operator-encryption
  • /test images
  • /test unit
  • /test verify

Use /test all to run all jobs.

In response to this:

/test e2e-aws-operator-encryption-perf

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@p0lyn0mial
Copy link
Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 30, 2020
@p0lyn0mial
Copy link
Author

the tests are green, @sanchezl ptal

@sttts
Copy link

sttts commented Nov 2, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 2, 2020
@p0lyn0mial
Copy link
Author

/retitle Bug 1893637: Fix bug in reflector not recovering from "Too large resource version"

@openshift-ci-robot openshift-ci-robot changed the title Bug 1880327: Fix bug in reflector not recovering from "Too large resource version" Bug 1893637: Fix bug in reflector not recovering from "Too large resource version" Nov 2, 2020
@openshift-ci-robot
Copy link

@p0lyn0mial: This pull request references Bugzilla bug 1893637, which is invalid:

  • expected dependent Bugzilla bug 1880327 to target a release in 4.6.0, 4.6.z, but it targets "4.5.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1893637: Fix bug in reflector not recovering from "Too large resource version"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@p0lyn0mial
Copy link
Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 2, 2020
@openshift-ci-robot
Copy link

@p0lyn0mial: This pull request references Bugzilla bug 1893637, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

8 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1880369 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent bug Bugzilla bug 1881819 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1880369 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • dependent Bugzilla bug 1881819 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 2, 2020
@wangke19
Copy link

wangke19 commented Nov 3, 2020

/bugzilla cc-qa

@openshift-ci-robot
Copy link

@wangke19: This pull request references Bugzilla bug 1893637, which is valid.

8 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1880369 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent bug Bugzilla bug 1881819 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1880369 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • dependent Bugzilla bug 1881819 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

Requesting review from QA contact:
/cc @wangke19

In response to this:

/bugzilla cc-qa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wangke19
Copy link

wangke19 commented Nov 3, 2020

Launched one 4.5 cluster with this PR successfully, verification steps see https://bugzilla.redhat.com/show_bug.cgi?id=1893637#c1

@wangke19
Copy link

wangke19 commented Nov 3, 2020

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, sttts, wangke19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 5, 2020
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f7a9be9 into openshift:release-4.5 Nov 5, 2020
@openshift-ci-robot
Copy link

@p0lyn0mial: All pull requests linked via external trackers have merged:

Bugzilla bug 1893637 has been moved to the MODIFIED state.

In response to this:

Bug 1893637: Fix bug in reflector not recovering from "Too large resource version"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanchezl sanchezl sanchezl left review comments

@sttts sttts Awaiting requested review from sttts

@wangke19 wangke19 Awaiting requested review from wangke19

Assignees

@sttts sttts

@sanchezl sanchezl

@wangke19 wangke19

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@p0lyn0mial @openshift-ci-robot @sanchezl @sttts @wangke19 @openshift-bot @sdodson @openshift-merge-robot