Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.7] Bug 1970127: UPSTREAM: <carry>: Change handler toleration to "operator: exists" (#… #194

Merged
merged 1 commit into from Sep 30, 2021
Merged

[release-4.7] Bug 1970127: UPSTREAM: <carry>: Change handler toleration to "operator: exists" (#… #194

merged 1 commit into from Sep 30, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #192

/assign cybertron

@cybertron
UPSTREAM: <carry>: Change handler toleration to "operator: exists" (n…
a49cf22 
…mstate#755)

Since nmstate is to be used for configuration of the network
infrastructure, we want the handler to run on all nodes regardless
of taint. If a network config should not run on a given node, the
NNCP nodeSelector field can be used to accomplish that.

For example, a node with a taint of:

[map[effect:NoSchedule key:node.ocs.openshift.io/storage value:true]]

will currently keep the nmstate handler pod from running there.
However, that is not desirable since it prevents the use of nmstate
to configure networking on that storage node.

This changes the handler toleration to "operator: exists", which
will allow the handler to run on all nodes. The webhook toleration
is left alone since there is no need for that to be running on
nodes with a NoSchedule taint.

Signed-off-by: Ben Nemec <bnemec@redhat.com>
(cherry picked from commit b2bccf9)
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 9, 2021
Merged
@openshift-ci
Copy link

openshift-ci bot commented Jun 9, 2021

@openshift-cherrypick-robot: Bugzilla bug 1960446 has been cloned as Bugzilla bug 1970127. Retitling PR to link against new bug.
/retitle [release-4.7] Bug 1970127: UPSTREAM: : Change handler toleration to "operator: exists" (#…

In response to this:

[release-4.7] Bug 1960446: UPSTREAM: : Change handler toleration to "operator: exists" (#…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.7] Bug 1960446: UPSTREAM: <carry>: Change handler toleration to "operator: exists" (#… [release-4.7] Bug 1970127: UPSTREAM: <carry>: Change handler toleration to "operator: exists" (#… Jun 9, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Jun 9, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 9, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1970127, which is invalid:

  • expected dependent Bugzilla bug 1960446 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.7] Bug 1970127: UPSTREAM: : Change handler toleration to "operator: exists" (#…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 9, 2021
@cybertron
Copy link
Member

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 3, 2021
@openshift-ci
Copy link

openshift-ci bot commented Aug 3, 2021

@cybertron: This pull request references Bugzilla bug 1970127, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1960446 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1960446 targets the "4.8.z" release, which is one of the valid target releases: 4.8.0, 4.8.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (osher@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qinqon
Copy link

qinqon commented Sep 30, 2021

/lgtm
/Approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2021
@openshift-merge-robot openshift-merge-robot merged commit 3ff052d into openshift:release-4.7 Sep 30, 2021
@openshift-ci
Copy link

openshift-ci bot commented Sep 30, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1970127 has been moved to the MODIFIED state.

In response to this:

[release-4.7] Bug 1970127: UPSTREAM: : Change handler toleration to "operator: exists" (#…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlonaKaplan AlonaKaplan Awaiting requested review from AlonaKaplan

@rhrazdil rhrazdil Awaiting requested review from rhrazdil

Assignees

@cybertron cybertron

@qinqon qinqon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@openshift-cherrypick-robot @cybertron @qinqon @openshift-merge-robot