Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.12] OCPBUGS-5476: Add empty spec to NMState CR example #330

Merged
merged 1 commit into from Jan 10, 2023
Merged

[release-4.12] OCPBUGS-5476: Add empty spec to NMState CR example #330

merged 1 commit into from Jan 10, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #329

/assign cybertron

@cybertron
Add empty spec to NMState CR example
de567b8 
The CVP tests are unhappy with the missing spec field, and although
we don't actually need or want one let's provide something to make
the check happy.

Note that the spec on NMState is largely used to control pod placement,
and the default behavior is what will be wanted in the majority of
cases. Setting any value on this object may result in undesirable
behavior.
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-5124 with correct target version. Retitling PR to link to clone:
/retitle [release-4.12] OCPBUGS-5476: Add empty spec to NMState CR example

In response to this:

This is an automated cherry-pick of #329

/assign cybertron

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 10, 2023
Merged
@openshift-ci openshift-ci bot changed the title [release-4.12] OCPBUGS-5124: Add empty spec to NMState CR example [release-4.12] OCPBUGS-5476: Add empty spec to NMState CR example Jan 10, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 10, 2023

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.12] OCPBUGS-5476: Add empty spec to NMState CR example

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 10, 2023
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-5476, which is invalid:

  • expected dependent Jira Issue OCPBUGS-5124 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #329

/assign cybertron

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from qinqon and yboaron January 10, 2023 17:07
@cybertron
Copy link
Member

/retest-required

@cybertron
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 10, 2023
@openshift-ci-robot
Copy link

@cybertron: This pull request references Jira Issue OCPBUGS-5476, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.0) matches configured target version for branch (4.12.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-5124 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-5124 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
  • bug has dependents

Requesting review from QA contact:
/cc @qiowang721

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 10, 2023
@cybertron
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2023
@davegord
Copy link

/retest

@openshift-merge-robot openshift-merge-robot merged commit 5c8d5a7 into openshift:release-4.12 Jan 10, 2023
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-5476 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #329

/assign cybertron

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinqon qinqon Awaiting requested review from qinqon

@yboaron yboaron Awaiting requested review from yboaron

@qiowang721 qiowang721 Awaiting requested review from qiowang721

Assignees

@cybertron cybertron

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@openshift-cherrypick-robot @openshift-ci-robot @cybertron @davegord @openshift-merge-robot