Skip to content

Commit

Permalink
Promote Ephemeral containers e2e test to Conformance
Browse files Browse the repository at this point in the history
  • Loading branch information
heyste committed May 28, 2023
1 parent b374404 commit 11a4040
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 1 deletion.
9 changes: 9 additions & 0 deletions test/conformance/testdata/conformance.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1950,6 +1950,15 @@
visible at runtime in the container.
release: v1.9
file: test/e2e/common/node/downwardapi.go
- testname: Ephemeral Container, update ephemeral containers
codename: '[sig-node] Ephemeral Containers [NodeConformance] should update the ephemeral
containers in an existing pod [Conformance]'
description: Adding an ephemeral container to pod.spec MUST result in the container
running. There MUST now be only one ephermal container found. Updating the pod
with another ephemeral container MUST succeed. There MUST now be two ephermal
containers found.
release: v1.28
file: test/e2e/common/node/ephemeral_containers.go
- testname: Ephemeral Container Creation
codename: '[sig-node] Ephemeral Containers [NodeConformance] will start an ephemeral
container in an existing pod [Conformance]'
Expand Down
10 changes: 9 additions & 1 deletion test/e2e/common/node/ephemeral_containers.go
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,15 @@ var _ = SIGDescribe("Ephemeral Containers [NodeConformance]", func() {
gomega.Expect(log).To(gomega.ContainSubstring("polo"))
})

ginkgo.It("should update the ephemeral containers in an existing pod", func(ctx context.Context) {
/*
Release: v1.28
Testname: Ephemeral Container, update ephemeral containers
Description: Adding an ephemeral container to pod.spec MUST result in the container
running. There MUST now be only one ephermal container found. Updating the pod with
another ephemeral container MUST succeed. There MUST now be two ephermal containers
found.
*/
framework.ConformanceIt("should update the ephemeral containers in an existing pod", func(ctx context.Context) {
ginkgo.By("creating a target pod")
pod := podClient.CreateSync(ctx, &v1.Pod{
ObjectMeta: metav1.ObjectMeta{Name: "ephemeral-containers-target-pod"},
Expand Down

0 comments on commit 11a4040

Please sign in to comment.