Skip to content

Commit

Permalink
OWNERS(CHANGELOG): Move reviewers/approvers to CHANGELOG/ dir
Browse files Browse the repository at this point in the history
Given we're pulling the relnotes team into review, the changes to
reviewers will happen a little more frequently, which means we'll have
the same issue of needing a top-level approver to do updates that we
were trying to avoid by creating the subdirectory in the first place.

Signed-off-by: Stephen Augustus <foo@auggie.dev>
(cherry picked from commit 5639cd9)
  • Loading branch information
justaugustus authored and hasheddan committed Feb 18, 2021
1 parent 147ff89 commit 11f5330
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 20 deletions.
16 changes: 14 additions & 2 deletions CHANGELOG/OWNERS
Original file line number Diff line number Diff line change
@@ -1,9 +1,21 @@
# See the OWNERS docs at https://go.k8s.io/owners

approvers:
- changelog-approvers
- wilsonehusin # 1.21 Release Notes Lead
- cpanato # Release Manager
- feiskyer # Release Manager
- hasheddan # Release Manager / SIG Technical Lead
- idealhack # Release Manager
- justaugustus # Release Manager / SIG Chair
- puerco # Release Manager
- saschagrunert # Release Manager / SIG Chair
- xmudrii # Release Manager
reviewers:
- changelog-reviewers
- wilsonehusin # 1.21 Release Notes Lead
- ashnehete # 1.21 Release Notes shadow
- melodychn # 1.21 Release Notes shadow
- pmmalinov01 # 1.21 Release Notes shadow
- soniasingla # 1.21 Release Notes shadow

labels:
- sig/release
Expand Down
18 changes: 0 additions & 18 deletions OWNERS_ALIASES
Original file line number Diff line number Diff line change
Expand Up @@ -153,24 +153,6 @@ aliases:
- puerco # Release Manager
- saschagrunert # Release Manager / SIG Chair
- xmudrii # Release Manager
changelog-approvers:
- wilsonehusin # 1.21 Release Notes Lead
- cpanato # Release Manager
- feiskyer # Release Manager
- hasheddan # Release Manager / SIG Technical Lead
- idealhack # Release Manager
- justaugustus # Release Manager / SIG Chair
- puerco # Release Manager
- saschagrunert # Release Manager / SIG Chair
- xmudrii # Release Manager
changelog-reviewers:
- wilsonehusin # 1.21 Release Notes Lead
# TODO(wilsonehusin): uncomment once ashnehete is an org member
# https://github.com/kubernetes/kubernetes/pull/97700#issuecomment-766734702
#- ashnehete # 1.21 Release Notes shadow
- melodychn # 1.21 Release Notes shadow
- pmmalinov01 # 1.21 Release Notes shadow
- soniasingla # 1.21 Release Notes shadow

sig-storage-approvers:
- saad-ali
Expand Down

0 comments on commit 11f5330

Please sign in to comment.