Remove noisy log

The error would be logged every reconciler sync (100 ms).
openshift · Aug 4, 2022 · 1490d51 · 1490d51
1 parent 0793ece
commit 1490d51
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/pkg/kubelet/volumemanager/cache/actual_state_of_world.go b/pkg/kubelet/volumemanager/cache/actual_state_of_world.go
@@ -824,10 +824,6 @@ func (asw *actualStateOfWorld) PodExistsInVolume(podName volumetypes.UniquePodNa
 				fullErr := newSELinuxMountMismatchError(volumeName)
 				if util.IsRWOP(volumeObj.spec) {
 					return false, volumeObj.devicePath, fullErr
-				} else {
-					// This is not an error yet, but it will be when support for RWO and RWX volumes is added
-					// TODO: bump some metric here
-					klog.V(4).ErrorS(fullErr, "Please report this error in https://github.com/kubernetes/enhancements/issues/1710, together with full Pod yaml file")
 				}
 			}
 		}

diff --git a/pkg/kubelet/volumemanager/reconciler/reconciler.go b/pkg/kubelet/volumemanager/reconciler/reconciler.go
@@ -221,7 +221,7 @@ func (rc *reconciler) mountOrAttachVolumes() {
 		volumeToMount.DevicePath = devicePath
 		if cache.IsSELinuxMountMismatchError(err) {
 			// TODO: check error message + lower frequency, this can be noisy
-			klog.ErrorS(err, volumeToMount.GenerateErrorDetailed("mount precondition failed", err).Error(), "pod", klog.KObj(volumeToMount.Pod))
+			klog.ErrorS(err, volumeToMount.GenerateErrorDetailed("mount precondition failed, please report this error in https://github.com/kubernetes/enhancements/issues/1710, together with full Pod yaml file", err).Error(), "pod", klog.KObj(volumeToMount.Pod))
 			// TODO: report error better, this may be too noisy
 			rc.desiredStateOfWorld.AddErrorToPod(volumeToMount.PodName, err.Error())
 		} else if cache.IsVolumeNotAttachedError(err) {