Skip to content

Commit

Permalink
[UT] increase coverage ut for kubeadm/app/features
Browse files Browse the repository at this point in the history
Signed-off-by: xin.li <xin.li@daocloud.io>
  • Loading branch information
my-git9 committed Jun 20, 2023
1 parent 1ff1a26 commit 180c233
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 10 deletions.
9 changes: 0 additions & 9 deletions cmd/kubeadm/app/features/features.go
Expand Up @@ -102,15 +102,6 @@ func Supports(featureList FeatureList, featureName string) bool {
return false
}

// Keys returns a slice of feature names for a given feature set
func Keys(featureList FeatureList) []string {
var list []string
for k := range featureList {
list = append(list, k)
}
return list
}

// KnownFeatures returns a slice of strings describing the FeatureList features.
func KnownFeatures(f *FeatureList) []string {
var known []string
Expand Down
33 changes: 32 additions & 1 deletion cmd/kubeadm/app/features/features_test.go
Expand Up @@ -207,13 +207,44 @@ func TestCheckDeprecatedFlags(t *testing.T) {
features: map[string]bool{"feature1": true},
expectedMsg: map[string]string{},
},
{
name: "invalid feature",
features: map[string]bool{"feature2": true},
expectedMsg: map[string]string{"feature2": "Unknown feature gate flag: feature2"},
},
}

for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
msg := CheckDeprecatedFlags(&someFeatures, test.features)
if !reflect.DeepEqual(test.expectedMsg, msg) {
t.Error("CheckDeprecatedFlags didn't returned expected message")
t.Errorf("CheckDeprecatedFlags() = %v, want %v", msg, test.expectedMsg)
}
})
}
}

func TestSupports(t *testing.T) {
tests := []struct {
name string
featureName string
want bool
}{
{
name: "the feature is not supported",
featureName: "foo",
want: false,
},
{
name: "the feature is supported",
featureName: PublicKeysECDSA,
want: true,
},
}
for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
if got := Supports(InitFeatureGates, test.featureName); got != test.want {
t.Errorf("Supports() = %v, want %v", got, test.want)
}
})
}
Expand Down

0 comments on commit 180c233

Please sign in to comment.